Permalink
Browse files

Increase prepare js timeout

Summary:
We run into this timeout virtually every live-reload now, which I believe is just a function of the size of our React Native code base. Looking at the code, right now the prepare JS call is run and retried 3 times, with a wait/timeout of 1s each. On android, it's done 3 times with a wait/timeout of 5s on each. For consistency, I've updated it to be the same timeout as on android. Trying this with our project, we no longer get red-boxes when we live-reload for the first time.

I've run this on our project locally, and it fixed the issue. It's a very simple change, so I don't believe any additional testing should be needed.

[IOS][BUGFIX][RCTWebsocketExecutor] - Increased timeout to prevent false-positive redbox during development of large RN code base
Closes #16794

Differential Revision: D6387545

Pulled By: shergin

fbshipit-source-id: c6e58fb82e072c01f9e1277a58d2640d6140a8c7
  • Loading branch information...
lelandrichardson authored and facebook-github-bot committed Nov 21, 2017
1 parent dc01eff commit b6f1a6085f7470c16ae8850e7da8f4f9ae5c23ee
Showing with 1 addition and 1 deletion.
  1. +1 −1 Libraries/WebSocket/RCTWebSocketExecutor.m
@@ -117,7 +117,7 @@ - (BOOL)prepareJSRuntime
initError = error;
dispatch_semaphore_signal(s);
}];
long runtimeIsReady = dispatch_semaphore_wait(s, dispatch_time(DISPATCH_TIME_NOW, NSEC_PER_SEC));
long runtimeIsReady = dispatch_semaphore_wait(s, dispatch_time(DISPATCH_TIME_NOW, NSEC_PER_SEC * 5));
if (initError) {
RCTLogInfo(@"Websocket runtime setup failed: %@", initError);
}

0 comments on commit b6f1a60

Please sign in to comment.