Fix infinite recursion in RCTSettingsManager init

Reviewed By: fromcelticpark Differential Revision: D5592555 fbshipit-source-id: edf5cdd91f057879edb22b8883902fec99b2d2cc
facebook · Aug 9, 2017 · b78b8cc · b78b8cc
1 parent d268c1f
commit b78b8cc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Libraries/Settings/RCTSettingsManager.h b/Libraries/Settings/RCTSettingsManager.h
@@ -13,6 +13,6 @@
 
 @interface RCTSettingsManager : NSObject <RCTBridgeModule>
 
-- (instancetype)initWithUserDefaults:(NSUserDefaults *)defaults;
+- (instancetype)initWithUserDefaults:(NSUserDefaults *)defaults NS_DESIGNATED_INITIALIZER;
 
 @end
diff --git a/Libraries/Settings/RCTSettingsManager.m b/Libraries/Settings/RCTSettingsManager.m
@@ -36,7 +36,7 @@ - (instancetype)init
 
 - (instancetype)initWithUserDefaults:(NSUserDefaults *)defaults
 {
-  if ((self = [self init])) {
+  if ((self = [super init])) {
     _defaults = defaults;