Skip to content

Commit

Permalink
[LOCAL] bypass tag check in dry run (#35428)
Browse files Browse the repository at this point in the history
  • Loading branch information
Riccardo committed Nov 22, 2022
1 parent 6107793 commit ba1a9de
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 9 deletions.
2 changes: 1 addition & 1 deletion scripts/bump-oss-version.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ async function main() {
);
const token = argv.token;
const releaseVersion = argv.toVersion;
failIfTagExists(releaseVersion);
failIfTagExists(releaseVersion, 'release');

const {pushed} = await inquirer.prompt({
type: 'confirm',
Expand Down
14 changes: 7 additions & 7 deletions scripts/prepare-package-for-release.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ const releaseVersion = argv.toVersion;
const isLatest = argv.latest;
const isDryRun = argv.dryRun;

failIfTagExists(releaseVersion);
const buildType = isDryRun
? 'dry-run'
: isReleaseBranch(branch)
? 'release'
: 'nightly';

failIfTagExists(releaseVersion, buildType);

if (branch && !isReleaseBranch(branch) && !isDryRun) {
console.error(`This needs to be on a release branch. On branch: ${branch}`);
Expand All @@ -60,12 +66,6 @@ if (branch && !isReleaseBranch(branch) && !isDryRun) {
exit(1);
}

const buildType = isDryRun
? 'dry-run'
: isReleaseBranch(branch)
? 'release'
: 'nightly';

const {version} = parseVersion(releaseVersion, buildType);
if (version == null) {
console.error(`Invalid version provided: ${releaseVersion}`);
Expand Down
8 changes: 7 additions & 1 deletion scripts/release-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,13 @@ function generateiOSArtifacts(
return tarballOutputPath;
}

function failIfTagExists(version) {
function failIfTagExists(version, buildType) {
// When dry-run in stable branch, the tag already exists.
// We are bypassing the tag-existence check when in a dry-run to have the CI pass
if (buildType === 'dry-run') {
return;
}

if (checkIfTagExists(version)) {
echo(`Tag v${version} already exists.`);
echo('You may want to rollback the last commit');
Expand Down

0 comments on commit ba1a9de

Please sign in to comment.