chore: update lint rules

.clang-format

@@ -1,49 +1,54 @@
+# The primary clang-format config file.
+# TODO(afuller): Set these settings when they aren't broken:
+# - AllowShortBlocksOnASingleLine: Empty
 ---
 AccessModifierOffset: -1
 AlignAfterOpenBracket: AlwaysBreak
+AlignConsecutiveMacros: false
 AlignConsecutiveAssignments: false
+AlignConsecutiveBitFields: false
 AlignConsecutiveDeclarations: false
-AlignEscapedNewlinesLeft: true
-AlignOperands:   false
+AlignEscapedNewlines: Left
+AlignOperands: DontAlign
 AlignTrailingComments: false
+AllowAllArgumentsOnNextLine: true
+AllowAllConstructorInitializersOnNextLine: true
 AllowAllParametersOfDeclarationOnNextLine: false
-AllowShortBlocksOnASingleLine: false
+AllowShortEnumsOnASingleLine: true
+AllowShortBlocksOnASingleLine: Never
 AllowShortCaseLabelsOnASingleLine: false
 AllowShortFunctionsOnASingleLine: Empty
-AllowShortIfStatementsOnASingleLine: false
+AllowShortLambdasOnASingleLine: All
+AllowShortIfStatementsOnASingleLine: Never
 AllowShortLoopsOnASingleLine: false
 AlwaysBreakAfterReturnType: None
 AlwaysBreakBeforeMultilineStrings: true
-AlwaysBreakTemplateDeclarations: true
+AlwaysBreakTemplateDeclarations: Yes
 BinPackArguments: false
 BinPackParameters: false
-BraceWrapping:
-  AfterClass:      false
-  AfterControlStatement: false
-  AfterEnum:       false
-  AfterFunction:   false
-  AfterNamespace:  false
-  AfterObjCDeclaration: false
-  AfterStruct:     false
-  AfterUnion:      false
-  BeforeCatch:     false
-  BeforeElse:      false
-  IndentBraces:    false
 BreakBeforeBinaryOperators: None
 BreakBeforeBraces: Attach
+BreakInheritanceList: BeforeColon
 BreakBeforeTernaryOperators: true
-BreakConstructorInitializersBeforeComma: false
+BreakConstructorInitializers: BeforeColon
 BreakAfterJavaFieldAnnotations: false
 BreakStringLiterals: false
-ColumnLimit:       80
-CommentPragmas:  '^ IWYU pragma:'
+ColumnLimit: 80
+CommentPragmas: '^ IWYU pragma:'
+CompactNamespaces: false
 ConstructorInitializerAllOnOneLineOrOnePerLine: true
 ConstructorInitializerIndentWidth: 4
 ContinuationIndentWidth: 4
 Cpp11BracedListStyle: true
+DeriveLineEnding: true
 DerivePointerAlignment: false
-DisableFormat:   false
-ForEachMacros:   [ FOR_EACH_RANGE, FOR_EACH, ]
+DisableFormat: false
+FixNamespaceComments: true
+ForEachMacros:
+  - FOR_EACH
+  - FOR_EACH_R
+  - FOR_EACH_RANGE
+IncludeBlocks: Preserve
 IncludeCategories:
   - Regex:           '^<.*\.h(pp)?>'
     Priority:        1
@@ -52,40 +57,58 @@ IncludeCategories:
   - Regex:           '.*'
     Priority:        3
 IndentCaseLabels: true
-IndentWidth:     2
+IndentCaseBlocks: false
+IndentGotoLabels: true
+IndentPPDirectives: None
+IndentExternBlock: AfterExternBlock
+IndentWidth: 2
 IndentWrappedFunctionNames: false
+InsertTrailingCommas: None
+JavaScriptQuotes: Leave
+JavaScriptWrapImports: true
 KeepEmptyLinesAtTheStartOfBlocks: false
 MacroBlockBegin: ''
-MacroBlockEnd:   ''
+MacroBlockEnd: ''
 MaxEmptyLinesToKeep: 1
 NamespaceIndentation: None
+ObjCBinPackProtocolList: Auto
 ObjCBlockIndentWidth: 2
-ObjCSpaceAfterProperty: true
-ObjCSpaceBeforeProtocolList: true
+ObjCBreakBeforeNestedBlockParam: true
+ObjCSpaceAfterProperty: false
+ObjCSpaceBeforeProtocolList: false
+PenaltyBreakAssignment: 2
 PenaltyBreakBeforeFirstCallParameter: 1
 PenaltyBreakComment: 300
 PenaltyBreakFirstLessLess: 120
 PenaltyBreakString: 1000
+PenaltyBreakTemplateDeclaration: 10
 PenaltyExcessCharacter: 1000000
 PenaltyReturnTypeOnItsOwnLine: 200
-PointerAlignment: Right
-ReflowComments:  true
-SortIncludes:    true
+PointerAlignment: Left
+ReflowComments: true
+SortIncludes: true
+SortUsingDeclarations: true
 SpaceAfterCStyleCast: false
+SpaceAfterLogicalNot: false
+SpaceAfterTemplateKeyword: true
 SpaceBeforeAssignmentOperators: true
+SpaceBeforeCpp11BracedList: false
+SpaceBeforeCtorInitializerColon: true
+SpaceBeforeInheritanceColon: true
 SpaceBeforeParens: ControlStatements
+SpaceBeforeRangeBasedForLoopColon: true
+SpaceInEmptyBlock: false
 SpaceInEmptyParentheses: false
 SpacesBeforeTrailingComments: 1
-SpacesInAngles:  false
+SpacesInAngles: false
+SpacesInConditionalStatement: false
 SpacesInContainerLiterals: true
 SpacesInCStyleCastParentheses: false
 SpacesInParentheses: false
 SpacesInSquareBrackets: false
-Standard:        Cpp11
-TabWidth:        8
-UseTab:          Never
----
-Language: ObjC
-ColumnLimit:     120
-BreakBeforeBraces: WebKit
+SpaceBeforeSquareBrackets: false
+Standard: Latest
+TabWidth: 8
+UseCRLF: false
+UseTab: Never
 ...

Libraries/AppDelegate/RCTAppDelegate.h

@@ -5,84 +5,97 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-#import <UIKit/UIKit.h>
 #import <React/RCTBridge.h>
 #import <React/RCTBridgeDelegate.h>
+#import <UIKit/UIKit.h>
 
 #if RCT_NEW_ARCH_ENABLED
-// When the new architecture is enabled, the RCTAppDelegate imports some additional headers
+// When the new architecture is enabled, the RCTAppDelegate imports some
+// additional headers
 #import <React/RCTCxxBridgeDelegate.h>
 #import <React/RCTSurfacePresenterBridgeAdapter.h>
 #import <ReactCommon/RCTTurboModuleManager.h>
 
-
 #endif
 
 /**
- * The RCTAppDelegate is an utility class that implements some base configurations for all the React Native apps.
+ * The RCTAppDelegate is an utility class that implements some base
+ configurations for all the React Native apps.
  * It is not mandatory to use it, but it could simplify your AppDelegate code.
  *
- * To use it, you just need to make your AppDelegate a subclass of RCTAppDelegate:
+ * To use it, you just need to make your AppDelegate a subclass of
+ RCTAppDelegate:
  *
  * ```objc
  * #import <React/RCTAppDelegate.h>
  * @interface AppDelegate: RCTAppDelegate
  * @end
  * ```
  *
- * All the methods implemented by the RCTAppDelegate can be overriden by your AppDelegate if you need to provide a
- custom implementation.
- * If you need to customize the default implementation, you can invoke `[super <method_name>]` and use the returned
- object.
+ * All the methods implemented by the RCTAppDelegate can be overriden by your
+ AppDelegate if you need to provide a custom implementation.
+ * If you need to customize the default implementation, you can invoke `[super
+ <method_name>]` and use the returned object.
  *
  * Overridable methods
  * Shared:
- *   - (RCTBridge *)createBridgeWithDelegate:(id<RCTBridgeDelegate>)delegate launchOptions:(NSDictionary *)launchOptions;
- *   - (UIView *)createRootViewWithBridge:(RCTBridge *)bridge moduleName:(NSString*)moduleName initProps:(NSDictionary *)initProps;
+ *   - (RCTBridge *)createBridgeWithDelegate:(id<RCTBridgeDelegate>)delegate
+ launchOptions:(NSDictionary *)launchOptions;
+ *   - (UIView *)createRootViewWithBridge:(RCTBridge *)bridge
+ moduleName:(NSString*)moduleName initProps:(NSDictionary *)initProps;
  *   - (UIViewController *)createRootViewController;
  * New Architecture:
  *   - (BOOL)concurrentRootEnabled
  *   - (NSDictionary *)prepareInitialProps
  *   - (Class)getModuleClassFromName:(const char *)name
- *   - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const std::string &)name
+ *   - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const
+ std::string &)name
                                                       jsInvoker:(std::shared_ptr<facebook::react::CallInvoker>)jsInvoker
- *   - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const std::string &)name
-                                                     initParams:
-                                                         (const facebook::react::ObjCTurboModule::InitParams &)params
+ *   - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const
+ std::string &)name initParams: (const
+ facebook::react::ObjCTurboModule::InitParams &)params
  *   - (id<RCTTurboModule>)getModuleInstanceFromClass:(Class)moduleClass
  */
-@interface RCTAppDelegate : UIResponder <UIApplicationDelegate, RCTBridgeDelegate>
+@interface RCTAppDelegate
+    : UIResponder<UIApplicationDelegate, RCTBridgeDelegate>
 
 /// The window object, used to render the UViewControllers
-@property (nonatomic, strong) UIWindow *window;
-@property (nonatomic, strong) RCTBridge *bridge;
-@property (nonatomic, strong) NSString *moduleName;
+@property(nonatomic, strong) UIWindow* window;
+@property(nonatomic, strong) RCTBridge* bridge;
+@property(nonatomic, strong) NSString* moduleName;
 
 /**
  * It creates a `RCTBridge` using a delegate and some launch options.
  * By default, it is invoked passing `self` as a delegate.
- * You can override this function to customize the logic that creates the RCTBridge
+ * You can override this function to customize the logic that creates the
+ * RCTBridge
  *
- * @parameter: delegate - an object that implements the `RCTBridgeDelegate` protocol.
+ * @parameter: delegate - an object that implements the `RCTBridgeDelegate`
+ * protocol.
  * @parameter: launchOptions - a dictionary with a set of options.
  *
  * @returns: a newly created instance of RCTBridge.
  */
-- (RCTBridge *)createBridgeWithDelegate:(id<RCTBridgeDelegate>)delegate launchOptions:(NSDictionary *)launchOptions;
+- (RCTBridge*)createBridgeWithDelegate:(id<RCTBridgeDelegate>)delegate
+                         launchOptions:(NSDictionary*)launchOptions;
 
 /**
- * It creates a `UIView` starting from a bridge, a module name and a set of initial properties.
- * By default, it is invoked using the bridge created by `createBridgeWithDelegate:launchOptions` and
- * the name in the `self.moduleName` variable.
- * You can override this function to customize the logic that creates the Root View.
+ * It creates a `UIView` starting from a bridge, a module name and a set of
+ * initial properties. By default, it is invoked using the bridge created by
+ * `createBridgeWithDelegate:launchOptions` and the name in the
+ * `self.moduleName` variable. You can override this function to customize the
+ * logic that creates the Root View.
  *
  * @parameter: bridge - an instance of the `RCTBridge` object.
- * @parameter: moduleName - the name of the app, used by Metro to resolve the module.
+ * @parameter: moduleName - the name of the app, used by Metro to resolve the
+ * module.
  * @parameter: initProps - a set of initial properties.
  *
  * @returns: a UIView properly configured with a bridge for React Native.
  */
-- (UIView *)createRootViewWithBridge:(RCTBridge *)bridge moduleName:(NSString*)moduleName initProps:(NSDictionary *)initProps;
+- (UIView*)createRootViewWithBridge:(RCTBridge*)bridge
+                         moduleName:(NSString*)moduleName
+                          initProps:(NSDictionary*)initProps;
 
 /**
  * It creates the RootViewController.
@@ -91,23 +104,29 @@
  *
  * @return: an instance of `UIViewController`.
  */
-- (UIViewController *)createRootViewController;
+- (UIViewController*)createRootViewController;
 
 @end
 
 #if RCT_NEW_ARCH_ENABLED
-/// Extension that makes the RCTAppDelegate conform to New Architecture delegates
-@interface RCTAppDelegate () <RCTTurboModuleManagerDelegate, RCTCxxBridgeDelegate>
+/// Extension that makes the RCTAppDelegate conform to New Architecture
+/// delegates
+@interface RCTAppDelegate ()<
+    RCTTurboModuleManagerDelegate,
+    RCTCxxBridgeDelegate>
 
 /// The TurboModule manager
-@property (nonatomic, strong) RCTTurboModuleManager *turboModuleManager;
-@property (nonatomic, strong) RCTSurfacePresenterBridgeAdapter *bridgeAdapter;
+@property(nonatomic, strong) RCTTurboModuleManager* turboModuleManager;
+@property(nonatomic, strong) RCTSurfacePresenterBridgeAdapter* bridgeAdapter;
 
-/// This method controls whether the `concurrentRoot`feature of React18 is turned on or off.
+/// This method controls whether the `concurrentRoot`feature of React18 is
+/// turned on or off.
 ///
 /// @see: https://reactjs.org/blog/2022/03/29/react-v18.html
-/// @note: This requires to be rendering on Fabric (i.e. on the New Architecture).
-/// @return: `true` if the `concurrentRoot` feature is enabled. Otherwise, it returns `false`.
+/// @note: This requires to be rendering on Fabric (i.e. on the New
+/// Architecture).
+/// @return: `true` if the `concurrentRoot` feature is enabled. Otherwise, it
+/// returns `false`.
 - (BOOL)concurrentRootEnabled;
 
 @end

packages/react-native-bots/dangerfile.js

@@ -12,6 +12,8 @@
 const {danger, fail, /*message,*/ warn} = require('danger');
 const includes = require('lodash.includes');
 const eslint = require('@seadub/danger-plugin-eslint');
+const {execSync} = require('child_process');
+const path = require('path');
 
 const isFromPhabricator =
   danger.github.pr.body &&
@@ -110,3 +112,24 @@ if (isMergeRefStable) {
 }
 
 eslint.default();
+
+// Run ClangFormat
+const extensions = new Set(['h', 'cpp', 'm', 'mm']);
+const clangFiles = danger.git.modified_files.filter(filename => {
+  const fileExt = filename.split('.').pop();
+  return extensions.has(fileExt);
+});
+if (clangFiles.length > 0) {
+  const clangFilesString = clangFiles
+      .map(filename => path.resolve('../..', filename)).join(' ');
+  const dryRunCommand = `npx clang-format -n ${clangFilesString} 2>&1`;
+  const inPlaceCommand = `npx clang-format -i ${clangFilesString}`;
+  const output = execSync(dryRunCommand);
+
+  if (output.length > 0) {
+    fail(`
+    There are some C++ or Objective-C files that are malformed.
+    Please run the following command and amend your commit:
+    \`${inPlaceCommand}\``);
+  }
+}