Skip to content

Commit

Permalink
Make Hermes from source the default
Browse files Browse the repository at this point in the history
Summary:
If Hermes is enabled, it will be built from source instead of using the CocoaPods hermes-engine pod.

Changelog:
[iOS] [Changed] Build Hermes from source when Hermes is used

Reviewed By: cortinico

Differential Revision: D35693945

fbshipit-source-id: eadc638106180b183fd6d1e2a272dc3df66fa8b6
  • Loading branch information
hramos authored and facebook-github-bot committed Apr 22, 2022
1 parent 2f5a1e6 commit bb01b75
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions scripts/react_native_pods.rb
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,9 @@ def use_react_native! (options={})

if hermes_enabled
pod 'React-hermes', :path => "#{prefix}/ReactCommon/hermes"
if ENV['BUILD_HERMES_SOURCE'] == '1'
Pod::UI.puts "[Hermes] Building Hermes from source"
hermes_source_path = downloadAndConfigureHermesSource(prefix)
pod 'hermes-engine', :path => "#{hermes_source_path}/hermes-engine.podspec"
else
Pod::UI.warn "[Hermes] Installing Hermes from CocoaPods. The `hermes-engine` pod has been deprecated and will not see future updates."
pod 'hermes-engine', '~> 0.11.0'
end
Pod::UI.puts "[Hermes] Building Hermes from source"
hermes_source_path = downloadAndConfigureHermesSource(prefix)
pod 'hermes-engine', :path => "#{hermes_source_path}/hermes-engine.podspec"
pod 'libevent', '~> 2.1.12'
end

Expand Down

0 comments on commit bb01b75

Please sign in to comment.