Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add TextInput's prop caretHidden implementation for Android and add t…
…he prop to docs Summary: This PR will: - add missing documentation for `caretHidden` prop to the docs - add `caretHidden` prop implementation for Android I noticed this by accident when looking at `RCTTextFieldManager.m` and there is `RCT_EXPORT_VIEW_PROPERTY(caretHidden, BOOL)` which hides caret on iOS. Then I realised that the docs were missing for this prop and implementation on Android side :) Render `TextInput` with prop `caretHidden`. After this caret is not visible anymore. `<TextInput style={styles.input} caretHidden />` If you omit the prop then caret is visible again `<TextInput style={styles.input} />` Closes #11863 Differential Revision: D4448402 fbshipit-source-id: 456e1df3e2cbb8af32540d2c7a8f4e7da219f5c3
- Loading branch information
bb1f851
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you guys add my name to release notes since I implemented this :D?
bb1f851
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henrikra sorry, just did that. it's a bit manual work since the commit doesn't have you as the user, probably because different email address.