Skip to content

Commit

Permalink
fix R8 warning (#27291)
Browse files Browse the repository at this point in the history
Summary:
R8 shows warning that **com.facebook.react.bridge.JavaScriptModule**, **com.facebook.react.bridge.NativeModule** are interfaces so proguard rules must use implements instead of extends. This PR changes proguard rules to fix the warnings.

## Changelog

[Android] [Changed] - Fix R8 warning
Pull Request resolved: #27291

Test Plan: RNTester builds and runs as expected.

Differential Revision: D18658704

Pulled By: mdvacca

fbshipit-source-id: a679643542bc55b89141f58c3236a29cf83c20d2
  • Loading branch information
dulmandakh authored and facebook-github-bot committed Nov 22, 2019
1 parent 03766d6 commit bbb4e44
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ReactAndroid/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
*** get*();
}

-keep class * extends com.facebook.react.bridge.JavaScriptModule { *; }
-keep class * extends com.facebook.react.bridge.NativeModule { *; }
-keep class * implements com.facebook.react.bridge.JavaScriptModule { *; }
-keep class * implements com.facebook.react.bridge.NativeModule { *; }
-keepclassmembers,includedescriptorclasses class * { native <methods>; }
-keepclassmembers class * { @com.facebook.react.uimanager.annotations.ReactProp <methods>; }
-keepclassmembers class * { @com.facebook.react.uimanager.annotations.ReactPropGroup <methods>; }
Expand Down

0 comments on commit bbb4e44

Please sign in to comment.