Skip to content

Commit

Permalink
Remove usages of listKey
Browse files Browse the repository at this point in the history
Summary:
Now that the prop noops, remove the usages of the property. This is the point of no return for the prop.

Replaced listKey usage with a combination of `flow check`, regex replace, manual inspection.

Changelog:
[General][Removed] - Remove usages of listKey

Reviewed By: fred2028

Differential Revision: D39589089

fbshipit-source-id: 722ebb7dce038a2709656394b7d736e72f488bb7
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Sep 20, 2022
1 parent 408471f commit bc5cb7c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
8 changes: 0 additions & 8 deletions Libraries/Lists/VirtualizedListProps.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,6 @@ type OptionalProps = {|
* Styling for internal View for ListHeaderComponent
*/
ListHeaderComponentStyle?: ViewStyleProp,
/**
* A unique identifier for this list. If there are multiple VirtualizedLists at the same level of
* nesting within another VirtualizedList, this key is necessary for virtualization to
* work properly.
*
* @deprecated no longer used/required
*/
listKey?: string,
/**
* The maximum number of items to render in each incremental render batch. The more rendered at
* once, the better the fill rate, but responsiveness may suffer because rendering content may
Expand Down
2 changes: 0 additions & 2 deletions packages/rn-tester/js/examples/FlatList/FlatList-nested.js
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ function OuterItemRenderer({
<View style={styles.col}>
<FlatList
data={items.map(i => index * items.length * 3 + i)}
listKey={`${index}-col1`}
renderItem={p => (
<InnerItemRenderer
item={p.item}
Expand All @@ -203,7 +202,6 @@ function OuterItemRenderer({
<View style={styles.col}>
<FlatList
data={items.map(i => index * items.length * 3 + i + items.length)}
listKey={`${index}-col2`}
renderItem={p => (
<InnerItemRenderer
item={p.item}
Expand Down

0 comments on commit bc5cb7c

Please sign in to comment.