Permalink
Browse files

Fix CocoaPods integration without DevSupport subspec

Summary:
This is the thing which is handled in https://github.com/orta/cocoapods-fix-react-native today.

https://github.com/orta/cocoapods-fix-react-native/blob/89a78ad34950b5d6b3de657914c8ced8bf37ee8e/lib/cocoapods-fix-react-native/versions/0_55_3-post.rb#L140-L164

This should be the correct fix for #17799.

<!--
  Required: Write your test plan here. If you changed any code, please provide us with
  clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
-->

Integrating React Native into an existing iOS project using CocoaPods without `DevSupport` subspec and seeing if the project successfully compiles.

<!--
  Required.
  Help reviewers and the release process by writing your own release notes. See below for an example.
-->

[IOS] [BUGFIX] [DevSupport] - Fix CocoaPods integration without DevSupport subspec
Closes #19265

Differential Revision: D8149786

Pulled By: hramos

fbshipit-source-id: c665e463b76aacdfb2022e82e36eb381d2d9ff2b
  • Loading branch information...
ikesyo authored and facebook-github-bot committed May 24, 2018
1 parent e1a36fc commit c09d509c2b8a5a02701829e1f0ace8081ce64277
Showing with 3 additions and 1 deletion.
  1. +3 −1 React/Modules/RCTDevSettings.mm
@@ -18,7 +18,6 @@
#import "RCTEventDispatcher.h"
#import "RCTJSCSamplingProfiler.h"
#import "RCTLog.h"
#import "RCTPackagerClient.h"
#import "RCTProfile.h"
#import "RCTUtils.h"
@@ -35,6 +34,7 @@
static NSString *const kRCTDevSettingsUserDefaultsKey = @"RCTDevMenu";
#if ENABLE_PACKAGER_CONNECTION
#import "RCTPackagerClient.h"
#import "RCTPackagerConnection.h"
#endif
@@ -201,6 +201,7 @@ - (void)setBridge:(RCTBridge *)bridge
#endif
}
#if ENABLE_PACKAGER_CONNECTION
static void pokeSamplingProfiler(RCTBridge *const bridge, RCTPackagerClientResponder *const responder)
{
if (!bridge) {
@@ -224,6 +225,7 @@ static void pokeSamplingProfiler(RCTBridge *const bridge, RCTPackagerClientRespo
[responder respondWithResult:results];
}
}
#endif
- (dispatch_queue_t)methodQueue
{

0 comments on commit c09d509

Please sign in to comment.