Fix SamplingProfiler and HeapCapture for apps that lazy load react mo…

…dules Reviewed By: cwdick Differential Revision: D4291903 fbshipit-source-id: 684ced8d6370494191cdb182a8e172680d69d17b
facebook · Dec 12, 2016 · d919eb7 · d919eb7
1 parent 8fb2440
commit d919eb7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/JSCHeapCapture.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/JSCHeapCapture.java
@@ -22,7 +22,9 @@
 import com.facebook.react.bridge.ReactMethod;
 import com.facebook.react.module.annotations.ReactModule;
 
-@ReactModule(name = "JSCHeapCapture")
+// This module is being called only by Java via the static method "captureHeap" that
+// requires it to alreay be initialized, thus we eagerly initialize this module
+@ReactModule(name = "JSCHeapCapture", needsEagerInit = true)
 public class JSCHeapCapture extends ReactContextBaseJavaModule {
   public interface HeapCapture extends JavaScriptModule {
     void captureHeap(String path);

diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/JSCSamplingProfiler.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/JSCSamplingProfiler.java
@@ -21,7 +21,9 @@
 import com.facebook.react.bridge.ReactMethod;
 import com.facebook.react.module.annotations.ReactModule;
 
-@ReactModule(name = "JSCSamplingProfiler")
+// This module is being called only by Java via the static method "poke" that
+// requires it to alreay be initialized, thus we eagerly initialize this module
+@ReactModule(name = "JSCSamplingProfiler", needsEagerInit = true)
 public class JSCSamplingProfiler extends ReactContextBaseJavaModule {
   public interface SamplingProfiler extends JavaScriptModule {
     void poke(int token);