Skip to content

Commit

Permalink
Do not add LongLivedObject wrapper in OSS (#35491)
Browse files Browse the repository at this point in the history
Summary:
This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library.

The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths,
within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this.

## Changelog

[iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec

Pull Request resolved: #35491

Test Plan: 1. Manually tested in an app from RC2

Reviewed By: cortinico

Differential Revision: D41548985

Pulled By: cipolleschi

fbshipit-source-id: acc57fccdedb344a3aa105f2968645a049392e07
  • Loading branch information
Riccardo Cipolleschi authored and facebook-github-bot committed Nov 29, 2022
1 parent 70bb644 commit dd0bf83
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ReactCommon/ReactCommon.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ Pod::Spec.new do |s|
sss.source_files = "react/nativemodule/core/ReactCommon/**/*.{cpp,h}",
"react/nativemodule/core/platform/ios/**/*.{mm,cpp,h}"
sss.dependency "React-jsidynamic", version
sss.exclude_files = "react/nativemodule/core/ReactCommon/LongLivedObject.h"
end

ss.subspec "samples" do |sss|
Expand Down

0 comments on commit dd0bf83

Please sign in to comment.