Skip to content

Commit

Permalink
Fix small props parsing bug for filter (#44637)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #44637

Setting the wrong thing to {}. `result` should be set here just like in the other early returns.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D57617046

fbshipit-source-id: e47dbdb7821879ffa02d11b7e68eec1c9bfbdefd
  • Loading branch information
joevilches authored and facebook-github-bot committed May 21, 2024
1 parent 644facd commit ed3f2f4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -833,7 +833,7 @@ inline void fromRawValue(
filter.push_back(filterPrimitive);
} catch (const std::exception& e) {
LOG(ERROR) << "Could not parse FilterPrimitive: " << e.what();
filter = {};
result = {};
return;
}
}
Expand Down

0 comments on commit ed3f2f4

Please sign in to comment.