Skip to content

Commit

Permalink
Stop unnecessarily spreading ReactNativeViewViewConfig
Browse files Browse the repository at this point in the history
Summary:
There's no need to spread ReactNativeViewViewConfig props into ViewConfig partials ourselves. createViewConfig does this for us:

https://www.internalfb.com/code/fbsource/[b319a947b3e5]/xplat/js/react-native-github/Libraries/NativeComponent/ViewConfig.js?lines=20-50

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D32187833

fbshipit-source-id: 6d7ea3fc808ccfc98e067f8f52334f7b3417d7a7
  • Loading branch information
RSNara authored and facebook-github-bot committed Nov 9, 2021
1 parent d29a6a1 commit f1f88b0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions Libraries/Components/TextInput/AndroidTextInputViewConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
* @format
*/

import ReactNativeViewViewConfig from '../../Components/View/ReactNativeViewViewConfig';
import type {PartialViewConfig} from 'react-native/Libraries/Renderer/shims/ReactNativeTypes';

const AndroidTextInputViewConfig = {
Expand Down Expand Up @@ -53,8 +52,6 @@ const AndroidTextInputViewConfig = {
},
directEventTypes: {},
validAttributes: {
...ReactNativeViewViewConfig.validAttributes,

maxFontSizeMultiplier: true,
adjustsFontSizeToFit: true,
minimumFontScale: true,
Expand Down
2 changes: 0 additions & 2 deletions Libraries/Components/TextInput/RCTTextInputViewConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
*/

import type {PartialViewConfig} from '../../Renderer/shims/ReactNativeTypes';
import ReactNativeViewViewConfig from '../../Components/View/ReactNativeViewViewConfig';

const RCTTextInputViewConfig = {
uiViewClassName: 'RCTSinglelineTextInputView',
Expand Down Expand Up @@ -72,7 +71,6 @@ const RCTTextInputViewConfig = {
},
directEventTypes: {},
validAttributes: {
...ReactNativeViewViewConfig.validAttributes,
fontSize: true,
fontWeight: true,
fontVariant: true,
Expand Down

0 comments on commit f1f88b0

Please sign in to comment.