Skip to content

Commit

Permalink
Set WebChromeClient to the android's WebView during instantiation
Browse files Browse the repository at this point in the history
Summary:Motivation: #6405

Follow up of: #6603

satya164
Closes #6880

Differential Revision: D3162425

fb-gh-sync-id: 1a91893c66da5550f47e8b801b3bd6079b4f5861
fbshipit-source-id: 1a91893c66da5550f47e8b801b3bd6079b4f5861
  • Loading branch information
lucasfeliciano authored and Facebook Github Bot 7 committed Apr 11, 2016
1 parent fcc89e9 commit f94abd3
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import android.text.TextUtils;
import android.webkit.WebView;
import android.webkit.WebViewClient;
import android.webkit.WebChromeClient;

import com.facebook.react.views.webview.events.TopLoadingErrorEvent;
import com.facebook.react.views.webview.events.TopLoadingFinishEvent;
Expand Down Expand Up @@ -243,6 +244,7 @@ public String getName() {
@Override
protected WebView createViewInstance(ThemedReactContext reactContext) {
ReactWebView webView = new ReactWebView(reactContext);
webView.setWebChromeClient(new WebChromeClient());
reactContext.addLifecycleEventListener(webView);
mWebViewConfig.configWebView(webView);

Expand Down

2 comments on commit f94abd3

@stereodenis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fullscreen video not working on android with this changes

@booyildirim
Copy link

@booyildirim booyildirim commented on f94abd3 Jan 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

embedded video is still not working on android.

Please sign in to comment.