Skip to content

Commit

Permalink
Downgrade warning about non-clippable views being clipped to no-crash…
Browse files Browse the repository at this point in the history
… exception

Summary:
This is crashing too much in debug, which is good signal but making it harder to test, and test unrelated features.

We have some good data about this internally and validated that it's useful; we can follow up on the logged soft exceptions without actually crashing now.

Changelog: [Internal]

Differential Revision: D29698447

fbshipit-source-id: 61387c18f17f76e5de60baa1fd3c94028229c0f6
  • Loading branch information
JoshuaGross authored and facebook-github-bot committed Jul 14, 2021
1 parent f00e348 commit ff9c8cd
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import com.facebook.common.logging.FLog;
import com.facebook.infer.annotation.Assertions;
import com.facebook.react.bridge.ReactContext;
import com.facebook.react.bridge.ReactNoCrashSoftException;
import com.facebook.react.bridge.ReactSoftException;
import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.common.annotations.VisibleForTesting;
Expand Down Expand Up @@ -575,7 +576,7 @@ public void run() {
if (!child.isShown()) {
ReactSoftException.logSoftException(
TAG,
new IllegalViewOperationException(
new ReactNoCrashSoftException(
"Child view has been added to Parent view in which it is clipped and not visible."
+ " This is not legal for this particular child view. Child: ["
+ child.getId()
Expand Down

0 comments on commit ff9c8cd

Please sign in to comment.