Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCTImageDownloader doesn't seem to be threadsafe #111

Closed
arunv opened this issue Feb 27, 2015 · 3 comments
Closed

RCTImageDownloader doesn't seem to be threadsafe #111

arunv opened this issue Feb 27, 2015 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@arunv
Copy link

arunv commented Feb 27, 2015

Repro:

Fire up the UIExplorer. Go to ListView, scroll all the way down. Go to ListView. You should hit an exception.

Seems to blame to c88a1cd: There's an NSMutableDictionary that is not threadsafe.
@vjeux
Copy link
Contributor

vjeux commented Feb 27, 2015

cc @a2

@arunv
Copy link
Author

arunv commented Feb 27, 2015

Ah formatting bug. Basically I can hit this by scrolling really fast down the Paging ListView.

I can fix it by locking the dictionary between changes, but that might hurt performance.

@arunv
Copy link
Author

arunv commented Mar 3, 2015

Added a pull request if you guys want to comment on it.

#117

@vjeux vjeux closed this as completed Apr 1, 2015
@Kureev Kureev mentioned this issue Feb 8, 2016
Closed
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
react-one pushed a commit to react-one/react-native that referenced this issue Sep 24, 2021
@satya164
fix: don't merge state with existing state during reset. fixes facebo…
7393464 
…ok#111
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vjeux @arunv @react-native-bot