Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packager 0.39] RN Packager doesn't see changes inside node_modules #11301

Closed
xxsnakerxx opened this issue Dec 5, 2016 · 12 comments · Fixed by jestjs/jest#2682
Closed

[Packager 0.39] RN Packager doesn't see changes inside node_modules #11301

xxsnakerxx opened this issue Dec 5, 2016 · 12 comments · Fixed by jestjs/jest#2682
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@xxsnakerxx
Copy link

xxsnakerxx commented Dec 5, 2016

Description

If I changing a file in my app folder, livereload and HMR works! But LR and HMR doesn't work if I changing a file inside node_modules directory (if stop packager process and start it again, the changes are applying)

With RN 0.38 - 0.38.1 all works fine!

Additional Information

  • React Native version: 0.39
  • Operating System: Mac OS Sierra
  • Watchman: 4.7.0
  • Node: 6.9.1
@asciiman
Copy link

asciiman commented Dec 5, 2016

I'm experiencing this too after upgrading to RN 0.39.
watchman 4.5.0

@Thomas101
Copy link
Contributor

We see exactly the same. Things that don't work our end...

  • Manually changing a file in node_modules (I know, I know, very bad!!)
  • npm install
  • npm install -f my_package_name
  • Changing a file in the main repository (which does get its changes reloaded) doesn't trigger the changes in node_modules to be reloaded

This is on Mac OS Sierra. Watchman 4.7.0. Node 6.3.1. React Native 0.39

@Exilz
Copy link

Exilz commented Dec 12, 2016

I'm experiencing this too with RN 0.39

@Clawg
Copy link

Clawg commented Dec 14, 2016

Same issue for me. Has anyone made any progress on this, I ended up rolling back to 0.38

@farwayer
Copy link
Contributor

@cpojer Can this regression be introduced by the packager refactoring?

@cpojer
Copy link
Contributor

cpojer commented Dec 26, 2016

yes, that is most likely the issue.

@jhen0409
Copy link
Contributor

jhen0409 commented Jan 6, 2017

Looks like the problem is related to jest-haste-map, the whilelist using providesModuleNodeModules (use for _isNodeModulesDir), so it will only process react-native, react-native-windows file changes. (JestHasteMap in node-haste)

It's broken my module development, a temporarily workaround is add the module name to providesModuleNodeModules, or can we provide an option for it?

@Exilz
Copy link

Exilz commented Jan 11, 2017

Any news ? This is a major issue :(

@Shenenkaka
Copy link

@jhen0409 temporary fix, thanks

@Exilz
Copy link

Exilz commented Feb 7, 2017

@cpojer when's jest latest version going to be out ? I guess once it's out, we will need to wait a newer release of react-native with the latest jest version as its dependency, right ?

@cpojer
Copy link
Contributor

cpojer commented Feb 7, 2017

soon!

@fadookie
Copy link
Contributor

fadookie commented Mar 17, 2017

@cpojer Thanks for getting this fixed! Any idea when react native will update to jest-haste-map 19?

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

Successfully merging a pull request may close this issue.