Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput displays placeholder on multiple lines when set dynamically on Android #14839

Closed
davidlongest opened this issue Jul 5, 2017 · 5 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@davidlongest
Copy link

Is this a bug report?

Yes

Have you read the Bugs section of the Contributing to React Native Guide?

Yes

Environment

  1. react-native -v:
react-native-cli: 2.0.1
react-native: 0.45.1
  1. node -v: v7.7.2
  2. npm -v: 4.1.2
  3. yarn --version (if you use Yarn): N/A

Then, specify:

  1. Target Platform (e.g. iOS, Android): Android
  2. Development Operating System (e.g. macOS Sierra, Windows 10): macOS Sierra 10.12.5
  3. Build tools (Xcode or Android Studio version, iOS or Android SDK version, if relevant): Android Studio 2.3.2. Compile SDK 23. Build tools 23.0.1

Steps to Reproduce

  1. Add a TextInput with no props set
  2. Set a placeholder that render longer than the TextInput is wide after the first render
  3. Do the same while setting the TextInput multiline prop to false.

Expected Behavior

On a TextInput with multiline undefined or false, the placeholder should only display a single line of text.

Actual Behavior

After the TextInput renders, it will display a second line of placeholder text halfway rendered and push the first line to the top of the view.

screen shot 2017-07-05 at 3 49 50 pm

Reproducible Demo

To see the issue. Launch the example project below and preview it. Once the application launches, wait a half second and note the placeholder text showing below the android underline.
https://snack.expo.io/SyE1ChqEb

@davidlongest
Copy link
Author

Also occurs on 0.46.0

@jzhan-canva
Copy link

+1 on 0.46.4, I think this is related to android version as well, not all my android devices have this issue, the only one has this is Android 5.1

@psteele2
Copy link

psteele2 commented Aug 7, 2017

👍

@pull-bot
Copy link

pull-bot commented Oct 9, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Oct 9, 2017
@hramos hramos closed this as completed Oct 9, 2017
@HemrajLodha
Copy link

numberOfLines prop not working in ios TextInput.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 9, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

7 participants