Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN 0.48.4 was tagged but not released #16022

Closed
vovkasm opened this issue Sep 20, 2017 · 5 comments
Closed

RN 0.48.4 was tagged but not released #16022

vovkasm opened this issue Sep 20, 2017 · 5 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@vovkasm
Copy link
Contributor

vovkasm commented Sep 20, 2017

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS Sierra 10.12.6
Node: 8.5.0
Yarn: Not Found
npm: 5.4.2
Watchman: 4.9.0
Xcode: Xcode 8.3.3 Build version 8E3004b
Android Studio: 2.3 AI-162.4069837

Packages: (wanted => installed)
react: 16.0.0-alpha.12 => 16.0.0-alpha.12
react-native: 0.48.3 => 0.48.3

Steps to Reproduce

  1. Project tests fails because of Tests failing on a newly created app #15810, and this was fixed in 0.48-stable branch in 355eaf7, release tag was created in b61fe7f
  2. npm outdated in project dir to see that update available
  3. npm info react-native | grep 0.48.4 to confirm that version 0.48.4 available

Expected Behavior

npm outdated should show something like:

Package                              Current           Wanted  Latest  Location
babel-preset-react-native              2.1.0            2.1.0   4.0.0  MyProject
react                        16.0.0-alpha.12  16.0.0-alpha.12  15.6.1  MyProject
react-native                          0.48.3           0.48.3  0.48.4  MyProject
react-test-renderer          16.0.0-alpha.12  16.0.0-alpha.12  15.6.1  MyProject

npm info react-native | grep 0.48.4 should return something like (time can be differrent):

'0.48.4': '2017-09-18T22:40:23.133Z'

Actual Behavior

npm outdated don't show react-native 0.48.4:

Package                              Current           Wanted  Latest  Location
babel-preset-react-native              2.1.0            2.1.0   4.0.0  MyProject
react                        16.0.0-alpha.12  16.0.0-alpha.12  15.6.1  MyProject
react-test-renderer          16.0.0-alpha.12  16.0.0-alpha.12  15.6.1  MyProject

npm info react-native | grep 0.48.4 don't return anything

@vovkasm
Copy link
Contributor Author

vovkasm commented Sep 20, 2017

Workaround to unblock developers who do TDD:
Place file jest/setup.js (name can vary):

const NativeModules = {
  BlobModule: {
    BLOB_URI_SCHEME: 'content',
    BLOB_URI_HOST: null,
    enableBlobSupport: jest.fn(),
    disableBlobSupport: jest.fn(),
    createFromParts: jest.fn(),
    sendBlob: jest.fn(),
    release: jest.fn(),
  },
}

Object.keys(NativeModules).forEach(name => {
  mockReactNativeModule(name, NativeModules[name])
})

function mockReactNativeModule(name, shape) {
  jest.doMock(name, () => shape, {virtual: true})
  require('react-native').NativeModules[name] = shape // this is bad, but I don't know how to modify jest mock
}

point jest setup to this file (most probably this is under "jest" key in package.json):

...
  "jest": {
    "preset": "react-native",
    "setupFiles": [
      "<rootDir>/jest/setup.js"
    ],
 ...

@grabbou
Copy link
Contributor

grabbou commented Sep 21, 2017

I am going to close this issue. I've removed the tag and scheduled yet another build. Looks like it failed because of website step which means there could've been race condition between few builds.

@grabbou grabbou closed this as completed Sep 21, 2017
@vovkasm
Copy link
Contributor Author

vovkasm commented Sep 21, 2017

Ok. Will wait. Just for notice. Recently I published to npm and was requested to confirm profile email. Publish to profiles with unconfirmed emails is locked...

@vovkasm
Copy link
Contributor Author

vovkasm commented Sep 21, 2017

@grabbou, 0.48.4 still not published in npm registry, so the bug not fixed. See my previous message... may be react-native-bot can't publish to npm, because it needs email verification.

@vovkasm
Copy link
Contributor Author

vovkasm commented Sep 23, 2017

@grabbou People opens new bugs because you close and not reopen this one. You closed this issue too early without test first, not a good practice :-/

Duplicate: #16074

@facebook facebook locked as resolved and limited conversation to collaborators Sep 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants