Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Support with 10.14's UIKit #19559

Closed
keplersj opened this issue Jun 4, 2018 · 9 comments
Closed

macOS Support with 10.14's UIKit #19559

keplersj opened this issue Jun 4, 2018 · 9 comments
Labels
Platform: iOS iOS applications. Platform: macOS Building on macOS. Stale There has been a lack of activity on this issue and it may be closed soon. Type: Discussion Long running discussion.

Comments

@keplersj
Copy link

keplersj commented Jun 4, 2018

For Discussion

Minutes ago Apple announced that the upcoming macOS 10.14 will support applications written with UIKit. Because React Native already implements iOS functionality using UIKit, will React Native support macOS using this existing codebase? Or will desktop functionality continue to be implemented outside of this repo like with react-native-macos (implemented with Cocoa/AppKit)?

@keplersj keplersj changed the title [Feature Request] macOS Support with 10.14's UIKit macOS Support with 10.14's UIKit Jun 4, 2018
@jeveloper
Copy link

You're quick :)

@react-native-bot react-native-bot added the Type: Discussion Long running discussion. label Jun 4, 2018
@avioli
Copy link

avioli commented Jun 4, 2018

Given react-native-macos requires macOS 10.11, then 10.14 is not too big of a jump as minimum requirement.

I only hope Apple rolls out docs for macOS UIKit support.

I wonder if the coordinate system is "fixed" - by default, the view’s coordinate system origin is located at the lower left on the Mac, not the upper left as on iOS.

@keplersj
Copy link
Author

keplersj commented Jun 9, 2018

@notjosh Did some experimentation and it looks like it'll completely possible in the future!

notjosh's twitter thread

notjosh's GitHub repo

@notjosh
Copy link
Contributor

notjosh commented Jun 9, 2018

hi! yes, it's very possible! three main things needed changing in react-native:

  1. converting CADisplayLink (I just used a 1/60 timer because CVDisplayLink is a pain, and it looks like we can probably use the macOS CADisplayLink eventually anyway)
  2. adding macOS targets to each of the projects
  3. add some #if TARGET_OS_OSX/#if TARGET_OS_IPHONE kind of checks for any unsupported code blocks (similar as is done for tvOS)

I can probably whittle it down to a patch if there's any significant interest?

@shirakaba
Copy link

Great interest here. I've been using react-native-macos and even released a WKWebView component for it (can be used as reference for making a macOS target, but honestly there's not much to it). It's a pity to have to deploy only to the latest macOS, but worth it in the long run to piggyback all the dev efforts relating to UIKit. react-native-macos has always been chasing behind RN master, and this would be a great way to keep the functionality in sync.

@hramos hramos added Platform: iOS iOS applications. Platform: macOS Building on macOS. labels Jun 18, 2018
@stale
Copy link

stale bot commented Feb 2, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 2, 2019
@brunolemos
Copy link
Contributor

Still interested. It would be much better than using Electron.

@ptmt
Copy link
Contributor

ptmt commented Feb 3, 2019 via email

@stale
Copy link

stale bot commented Feb 10, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Feb 10, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Feb 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Platform: iOS iOS applications. Platform: macOS Building on macOS. Stale There has been a lack of activity on this issue and it may be closed soon. Type: Discussion Long running discussion.
Projects
None yet
Development

No branches or pull requests

9 participants