Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

["Discussion"] Remove android platform and platform-tools install validation. #22778

Closed
gengjiawen opened this issue Dec 24, 2018 · 5 comments
Closed
Labels
Contributor A React Native contributor. Partner Platform: Android Android applications. Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.

Comments

@gengjiawen
Copy link
Contributor

They can automatically install by android sdk manager.

You can see https://gitlab.com/gengjiawen/ci-sample/-/jobs/138463124.
Android sdk 27 and 27.0.3 is automatically install.

Checking the license for package Android SDK Build-Tools 27.0.3 in /opt/android/licenses
License for package Android SDK Build-Tools 27.0.3 accepted.
Preparing "Install Android SDK Build-Tools 27.0.3 (revision: 27.0.3)".
"Install Android SDK Build-Tools 27.0.3 (revision: 27.0.3)" ready.
Installing Android SDK Build-Tools 27.0.3 in /opt/android/build-tools/27.0.3
"Install Android SDK Build-Tools 27.0.3 (revision: 27.0.3)" complete.
"Install Android SDK Build-Tools 27.0.3 (revision: 27.0.3)" finished.
Checking the license for package Android SDK Platform 27 in /opt/android/licenses
License for package Android SDK Platform 27 accepted.
Preparing "Install Android SDK Platform 27 (revision: 3)".
"Install Android SDK Platform 27 (revision: 3)" ready.
Installing Android SDK Platform 27 in /opt/android/platforms/android-27
"Install Android SDK Platform 27 (revision: 3)" complete.
"Install Android SDK Platform 27 (revision: 3)" finished.
@gengjiawen gengjiawen added the Type: Discussion Long running discussion. label Dec 24, 2018
@gengjiawen
Copy link
Contributor Author

cc @hramos @dulmandakh

@dulmandakh
Copy link
Contributor

what is your RN version? IIRC, master has Android Support Library 28.0.0, but your CI shows 27.1.1

@gengjiawen
Copy link
Contributor Author

I want to remove the check in bash. The log as an evidence to show sdkmanager can auto install missing component.

@dulmandakh
Copy link
Contributor

I would say go ahead and create a PR 👍

@hramos hramos added Partner Contributor A React Native contributor. and removed Core Team labels Mar 8, 2019
@cpojer
Copy link
Contributor

cpojer commented Mar 19, 2019

This issue was a discussion and we agreed that a PR should be sent. @gengjiawen please consider sending a PR with the fix but I'm gonna close the issue because on its own it isn't actionable.

@cpojer cpojer closed this as completed Mar 19, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Mar 19, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contributor A React Native contributor. Partner Platform: Android Android applications. Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.
Projects
None yet
Development

No branches or pull requests

5 participants