Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Native London Issue Triage #24032

Closed
cpojer opened this issue Mar 19, 2019 · 4 comments
Closed

React Native London Issue Triage #24032

cpojer opened this issue Mar 19, 2019 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.

Comments

@cpojer
Copy link
Contributor

cpojer commented Mar 19, 2019 •
edited by kelset
Loading

Goal: Reduce open issues on the React Native repository by resolving, fixing, closing and otherwise handling existing issues in a way that is satisfying to our users.

Time: Tuesday, March 19th

Approach: Split into groups of 3-4 people based on (mixed or common) expertise and assign a bucket of issues to work on throughout the day. We aim to leave a comment on 60-70% of all open issues with further steps. Make sure you learn something from others and have fun!

Proposed Flow

  • Sit together in a group of 3-4 people, organize in any way you prefer.
  • Try to go through as many issues as possible throughout the day.
  • Be as nice as possible in your replies.
  • Leave a comment on every issue that you are looking at.
  • Sweep: Divide the issues and go through them individually. Handle the easy ones first, and note the harder ones to work on together later.
  • Check handled issues from the issue triage bucket.
  • Encourage people to send Pull Requests with fixes, even if we close things.
  • Ask for a repro and add the “Resolution: Needs Repro”, “Follow-up” label.
  • Add high-pri tag if issue requires fixing within the next month
  • Add low-pri tag if issue is not important enough for us to be fixed within the next three months
  • Add mid-pri tag if in between
  • If you are unsure, ask for a follow-up from the author. Add the “Follow-up” label so that somebody from FB can check the issue in a few weeks.
  • Move if the issue is related to something in a community repo
    • Send a message to @cpojer with the issue id + the repo it should be moved to.
  • Escalate to FB employees if it requires attention by FB
  • Close if
    • …the last comment is asking for a repro and is older than a week
    • …the issue is no longer relevant (ie. extraction of the module through lean core, removed feature, etc.)
    • …the issue does not reproduce
    • …the issue has had no activity for a while
    • …the issue was created prior to 0.57 and had little interaction since

People

Team Name Alias
The A-Team Lorenzo Sciandra @kelset
The A-Team Eli White @TheSavior
The A-Team Mike Diarmid @Salakar
The A-Team Thibault Malbranche @Titozzz
Mike Drop Orta Theroux @orta
Mike Drop Mike Grabowski @grabbou
Mike Drop Rick Hanlon @rickhanlonii
X Christoph Nakazawa @cpojer
Closers Michal Pierzchala @thymikee
Closers Bartol Karuza @bartolkaruza
Closers Eloy Duran @alloy
Turbo Dulmandakh Sukhbaatar @dulmandakh
Turbo Ferran Negre @ferrannp
Turbo Michal Chudziak @michalchudziak

Issue Buckets

Issues are bucketed in a way so that every team receives roughly the same set of issues from high engagement to low engagement.

Canned Replies

Use these for your replies if you like.

Upgrading to 0.59

Hello there 👋 this issue seems to be related to your experience upgrading between versions. We know this has been a [long lasting pain for the community](https://github.com/react-native-community/discussions-and-proposals/issues/68) so starting v0.59 we have introduced a new flow via the [new CLI](https://facebook.github.io/react-native/blog/#cli-improvements).

To upgrade to that version, you may still need to do some manual steps – we suggest you use [rn-diff-repo](https://github.com/pvinis/rn-diff-purge) to accomplish this.

Given that this is not strictly a bug with the library itself I'll close this, but if someone can create a repro that has this issue with a freshly created `react-native init` project we can reopen it and discuss it further 🤗

There is no repro / don't want to post repro

Hello there 👋 this issue doesn't have a repro (which means, a `react-native init`-ed project with the minimal changes that leads to creating the same issue you are reporting). Unfortunately, I have no way of helping you in a meaningful way – there is no easy way for me to recreate the situation and check that the issue reported is still there when changing the code.

Because of this, we are going to close this issue - but if a repro is shared, we are happy to reopen it 🤗

Issue is stale / There has been no activity

Hello there 👋 this issue seems to have been inactive for the past few weeks. Because of this, it's likely that the issue is not a high priority anymore or it has been solved by OP; for these reasons, we'll close it. But please, if it's actually still an issue with 0.59 please comment below and we can reopen it or please send us a Pull Request with a fix 😊

Issue can't be reproduced

Hello there 👋 by using the repro / the list of steps to reproduce, we can't actually see the reported bug on RN 0.59 so we'll close this issue. It may have something to do with your local setup, please double check that you are using the correct version of Android Studio / XCode / Android NDK / Yarn / etc.

Issue is on old version

Hello there 👋 this issue has been reported for an old version of React Native. Ideally we'd like everyone to be using 0.59 (see the [awesome changes](https://facebook.github.io/react-native/blog/2019/03/12/releasing-react-native-059) it brought) but we know updating can be a pain. We are going to close this issue because it's from a version before 0.57, which is really old.

But please, if it's actually still an issue with 0.59 please comment below and we can reopen it. Even better, please send us a pull request with a fix 😊

Issue is a feature request

Hello there 👋 this issue seems more of a precise feature request than a bug report. For this reason, we'd prefer for you to post it to [Canny](https://react-native.canny.io/feature-requests) so that it can be prioritized against the FR already there (maybe someone already submitted it!).

Issue is a discussion or proposal

Hello there 👋 this issue seems more of a long form conversation to be had; for this reason, we'd prefer to migrate it to the dedicated [discussion-and-proposals](https://github.com/react-native-community/discussions-and-proposals/) repo so that it won't be lost in the noise of the many bug reports being submitted.

Issue is super inactive

Hello there 👋 this issue seems to have a really low activity on it. This is probably because OP managed to find a solution - also, it was most likely related their precise configuration. Because of this inactivity, we are closing it - but please feel free to comment and post a repro for version 0.59 and we'll gladly re-open it 🤗
@cpojer
Copy link
Contributor Author

cpojer commented Mar 19, 2019 •
edited
Loading

Discussions to be handled by FB:

Discussions

@kelset kelset added the Type: Discussion Long running discussion. label Mar 19, 2019
@react-native-bot

This comment has been minimized.

Sign in to view
@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Resolution: Needs More Information labels Mar 19, 2019
@cpojer cpojer pinned this issue Mar 19, 2019
@hramos hramos removed Ran Commands One of our bots successfully processed a command. Type: Bug Report labels Mar 19, 2019
@cpojer
Copy link
Contributor Author

cpojer commented Mar 19, 2019

This was an incredibly successful day. We started with ~680 open issues and finished just shy of 400 issues. Thank you so much to all the people from the A-Team, Mike-Drop, Closers and Turbo teams who spend a full day triaging and handling issues. We are now gonna go for a nice dinner together, I think we deserve it :)

@cpojer cpojer closed this as completed Mar 19, 2019
@orta
Copy link
Contributor

orta commented Mar 19, 2019

2019-03-19 17-51-07 2019-03-19 17_52_09

@cpojer cpojer unpinned this issue Mar 19, 2019
@kelset kelset mentioned this issue Mar 25, 2019
Open
@facebook facebook locked as resolved and limited conversation to collaborators Mar 19, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cpojer @orta @hramos @kelset @react-native-bot