Remove android initialAppState fallback check #23487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 17, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@zhongwuzw merged commit f95876b into |
ericlewis
pushed a commit
to ericlewis/react-native
that referenced
this pull request
Feb 20, 2019
Summary: 1. We expose the `initialAppState` for Android in facebook#19935, so we can remove the fallback check for Android. 2. Rename `RCTCurrentAppBackgroundState` to `RCTCurrentAppState`, it's a private file function, so it's safe to rename, `RCTCurrentAppState` is more suitable because we actually get app state, not app background state. [Android] [Enhancement] - Remove android `initialAppState` fallback check. Pull Request resolved: facebook#23487 Differential Revision: D14121293 Pulled By: cpojer fbshipit-source-id: fec196cef2969fe6f6f1571f4ebcafcec26266a1
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
initialAppStatefor Android in Expose initialAppState constant from Android native AppState module #19935, so we can remove the fallback check for Android.RCTCurrentAppBackgroundStatetoRCTCurrentAppState, it's a private file function, so it's safe to rename,RCTCurrentAppStateis more suitable because we actually get app state, not app background state.Changelog
[Android] [Enhancement] - Remove android
initialAppStatefallback check.Test Plan
Android support
initialAppState.