-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose initialAppState constant from Android native AppState module #19935
Conversation
@boguscoder I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
@boguscoder I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zpao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Oleg Bogdanov merged commit 5c0dcdd into |
…acebook#19935) Summary: This PR addresses TODO left in _AppState.js_ The goal is to align AppState module implementation between iOS and Android. iOS native module exposes _initialAppState_ constant that AppState.js relies on, while Android doesn't expose that constant and js implementation uses a fallback. This PR aims to remove a need for a fallback Pull Request resolved: facebook#19935 Reviewed By: hramos Differential Revision: D13774044 Pulled By: ejanzer fbshipit-source-id: 05d27e702cb9aeedf14293158bfd50004df4726b
This PR addresses TODO left in AppState.js
The goal is to align AppState module implementation between iOS and Android. iOS native module exposes initialAppState constant that AppState.js relies on, while Android doesn't expose that constant and js implementation uses a fallback. This PR aims to remove a need for a fallback
Test Plan:
Changes were tested with the help of debugger and a test Android application:
Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[ANDROID] [TODO] [AppState] - Exposed initialAppState constant from Android native AppState module