Open links from new app screen in computer's browser #24843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cpojer
approved these changes
May 14, 2019
facebook-github-bot
approved these changes
May 14, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
thymikee
reviewed
May 14, 2019
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
thymikee
approved these changes
May 14, 2019
|
This pull request was successfully merged by @lucasbento in aa926e3. When will my fix make it into a release? | Upcoming Releases |
|
It looks like |
|
Here's how I verified the regression was introduced in the commit associated with this PR:
|
|
We have a fix for that coming: react-native-community/cli#376 will prioritize it today |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 16, 2019
Summary: PR #24843 broke Android tests because of a regression we introduced in terms of passing `reporter` argument to Metro config. This was fixed in latest `alpha.20` release of CLI ## Changelog [General] [Fix] - update CLI to alpha.20 to fix Android tests Pull Request resolved: #24869 Reviewed By: rickhanlonii Differential Revision: D15355144 Pulled By: cpojer fbshipit-source-id: faafd8098c708845264b7164557076bce45ea332
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: PR facebook#24843 broke Android tests because of a regression we introduced in terms of passing `reporter` argument to Metro config. This was fixed in latest `alpha.20` release of CLI ## Changelog [General] [Fix] - update CLI to alpha.20 to fix Android tests Pull Request resolved: facebook#24869 Reviewed By: rickhanlonii Differential Revision: D15355144 Pulled By: cpojer fbshipit-source-id: faafd8098c708845264b7164557076bce45ea332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is related to #24760 and adds the
openURLInBrowserfunctionality introduced on react-native-community/cli#383.Changelog
[General] [Changed] - Open links from new app in computer's browser.
Test Plan
npm ito install the new dep (bumped@react-native-community/clitov2.0.0-alpha.19);RNTester/RNTesterPods.xcworkspace;newin the list of theRNTester, tap the first item and click on any link, that link should open in your computer's default browser.If any of these steps don't work please let me know and we will fix them.
cc @cpojer.