-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New App Screen #24760
Comments
Thanks for submitting your issue. Can you take another look at your description and make sure the issue template has been filled in its entirety? 👉 Click here if you want to take another look at the Bug Report issue template. |
I would love to help on this, specially the opening links on the browser part. Would this be targeting 0.61? I'm currently busy with some stuff for the CLI but I would probably be able to do some stuff for this next week. |
Yep, 0.61. Ideally we'll wrap this work up by the end of the month. |
Can you run If you believe this information is irrelevant to the reported issue, you may write `[skip envinfo]` alongside an explanation in your Environment: section.
|
Summary: Related to #24760 and #24737 This simplifies some styling within the components used for the New App Screen to help advocate for best practices when styling with CSS-like styles in React Native, as well as using React Native's own unique components. There's a bit more detail in each commit. Let me know if you'd like me to pull that info out into the PR description here! [General] [Changed] - Polished up new app screen component styling Pull Request resolved: #24783 Differential Revision: D15284851 Pulled By: cpojer fbshipit-source-id: 954db00d39fc0082bbd4dc96afa7d38dfb7f67d5
@eliperkins do you wanna take care of adding a follow on twitter link + putting it into the actual template? :) |
@cpojer sure thing. I'll tackle the moving to the template part now that the polish PR has landed. As for the Twitter link, do you expect that to be a link to https://twitter.com/reactnative or is there another, more follow-specific link that we can put in there? |
Yep, that links is good :) |
@ericlewis opened a PR for the open in browser functionality on CLI: react-native-community/cli#383. |
Alright, so the main remaining thing is to hook up @ericlewis's new feature with the buttons in the new app screen. @lucasbento could you make that happen? Ideally if you could add a video in the test plan to show that it works that would be best :D |
Summary: This adds in a link to the reactnative Twitter handle so our users can follow along with the latest and greatest of React Native! Related to #24760 [General] [Added] - Added link to reactnative Twitter handle to Learn More section Pull Request resolved: #24806 Differential Revision: D15316771 Pulled By: cpojer fbshipit-source-id: cd45f005cfbcbd277fadb48be8943d60f4386767
Summary: This replaces the "new app screen" in the template with the new design from react-native-community/discussions-and-proposals#122 This uses components that are shipped as part of the `react-native` module, but not necessarily as proper components exported by the main `react-native` module. To use these, we use absolute imports to those components. Related to #24760 [General] [Changed] - Updated new app template design 💖 Pull Request resolved: #24805 Differential Revision: D15334459 Pulled By: cpojer fbshipit-source-id: d0b67d08f936eeabd9e93d4e0ff78302b4d6429f
Summary: This PR is related to #24760 and adds the `openURLInBrowser` functionality introduced on react-native-community/cli#383. [General] [Changed] - Open links from new app in computer's browser. Pull Request resolved: #24843 Reviewed By: rickhanlonii Differential Revision: D15334011 Pulled By: cpojer fbshipit-source-id: 947ad1b113923989cf706e60851e02a87e1099e8
Thank you everyone for making this happen. This was a super awesome collaboration between so many people. @rickhanlonii and I made a brief video to show off the new screen: https://www.youtube.com/watch?v=ImlAqMZxveg&feature=youtu.be |
@cpojer Can we upgrade typescript template to support this? Typescript template is still using old screen.. |
Give it a shot at updating yourself @gamingumar - I think it's this one: https://github.com/react-native-community/react-native-template-typescript |
Hi @orta Sure, I can create a PR for it, just need an input where should that typescript template live? As this one lives in react-native/Libraries |
This is the list of remaining things to do before we can ship the new app screen (see react-native-community/discussions-and-proposals#122). The initial version of the code was landed via #24737:
cc @eliperkins @lucasbento would be awesome if you could help out! :)
The text was updated successfully, but these errors were encountered: