Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput flow type for props is not exported #26263

Closed
vasilich6107 opened this issue Aug 29, 2019 · 4 comments
Closed

TextInput flow type for props is not exported #26263

vasilich6107 opened this issue Aug 29, 2019 · 4 comments
Labels
Bug Component: TextInput Related to the TextInput component. Flow Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@vasilich6107
Copy link
Contributor

If we look through this file we can see that there are a lot of types are exported.
https://github.com/facebook/react-native/blob/master/Libraries/Components/TextInput/TextInput.js

But the main type type Props = {...} is not exported.

I'm using react-native-material-textfield(https://github.com/n4kz/react-native-material-textfield) and I can not make proper typings for it cause I'm not able to write something like:

import type { TextFieldProps } from 'react-native-material-textfield';
import type { Props } from 'react-native/Libraries/Components/TextInput/TextInput';

type ResultingProps = {|
    ...TextFieldProps,
    ...Props
|};

React Native version:
0.60.4

Steps To Reproduce

Look at this line
https://github.com/facebook/react-native/blob/master/Libraries/Components/TextInput/TextInput.js#L412

Describe what you expected to happen:
Could you add export to the type Props in nearest release?

@react-native-bot react-native-bot added Component: TextInput Related to the TextInput component. Flow labels Aug 29, 2019
@vasilich6107
Copy link
Contributor Author

Any comments?

@vasilich6107
Copy link
Contributor Author

Is there anybody?

facebook-github-bot pushed a commit that referenced this issue Sep 30, 2019
Summary:
Fix for issue #26263

## Changelog

[JavaScript] [Fixed] - Added an export for TextInput props type
Pull Request resolved: #26622

Test Plan: This PR does not change user interface

Differential Revision: D17661069

Pulled By: cpojer

fbshipit-source-id: 7a8e0159de9dc9e775eae349d0f1e743155e56db
@stale
Copy link

stale bot commented Dec 26, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Dec 26, 2019
@stale
Copy link

stale bot commented Jan 2, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Jan 2, 2020
@facebook facebook locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Component: TextInput Related to the TextInput component. Flow Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

2 participants