remove xcshareddata from gitignore
#27563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is meant to be shared
facebook-github-bot
added
the
CLA Signed
|
Looks like this was added by @karanjthakkar in #25451 |
|
Ah, good spotting. I remember writing about this, but I couldn't find it. Anyway, like I said there, |
facebook-github-bot
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @pvinis in 7980615. When will my fix make it into a release? | Upcoming Releases |
6 tasks
alloy
pushed a commit
that referenced
this pull request
Feb 25, 2020
Summary: Files that are inside `xcshareddata` are meant to be "shared", and that means committed to git. These files are for example `ios/RnDiffApp.xcodeproj/xcshareddata/xcschemes/RnDiffApp.xcscheme`, and if ignored that means they are removed from the repo or are missing when cloning. These should be present. They are the shared schemes so Xcode knows what and how to build, on everyone's machine. I noticed it being there in a new project on 0.62.0-rc.0. ## Changelog [iOS] [Changed] - Remove the xcshareddata from .gitignore Pull Request resolved: #27563 Differential Revision: D19166364 Pulled By: TheSavior fbshipit-source-id: 0377dc5b08ba04d121f9ed5e4027942a7a9f463f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Files that are inside
xcshareddataare meant to be "shared", and that means committed to git. These files are for exampleios/RnDiffApp.xcodeproj/xcshareddata/xcschemes/RnDiffApp.xcscheme, and if ignored that means they are removed from the repo or are missing when cloning. These should be present. They are the shared schemes so Xcode knows what and how to build, on everyone's machine.I noticed it being there in a new project on 0.62.0-rc.0.
Changelog
[iOS] [Changed] - Remove the xcshareddata from .gitignore
Test Plan