Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackHandler: specify function return type for handler #28192

Closed
wants to merge 3 commits into from

Conversation

Naturalclar
Copy link
Contributor

Summary

Following the comment DefinitelyTyped/DefinitelyTyped#42618 (comment)

Modify the flowtype of BackHandler function to have more specific return type.

Changelog

[General] [Changed] - Changed type of BackHandler to be more specific.

Test Plan

No flow error in RNTester

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2020
@analysis-bot
Copy link

RNTester (Android/hermes/arm64-v8a): 3291136 bytes
RNTester (Android/hermes/armeabi-v7a): 3131392 bytes
RNTester (Android/hermes/x86): 3463168 bytes
RNTester (Android/hermes/x86_64): 3426304 bytes
RNTester (Android/jsc/arm64-v8a): 4446208 bytes
RNTester (Android/jsc/armeabi-v7a): 4268032 bytes
RNTester (Android/jsc/x86): 4360192 bytes
RNTester (Android/jsc/x86_64): 4646912 bytes

@analysis-bot
Copy link

RNTester.app (iOS): 10657792 bytes

Copy link
Contributor

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙆‍♂

@analysis-bot
Copy link

analysis-bot commented Mar 31, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 809,568 -9,850,496

Base commit: 25793ea

@alloy
Copy link
Contributor

alloy commented Mar 31, 2020

@TheSavior Can you merge this? 🙏

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,760,906 0
android hermes armeabi-v7a 6,407,914 0
android hermes x86 7,143,116 0
android hermes x86_64 7,033,841 0
android jsc arm64-v8a 8,929,410 0
android jsc armeabi-v7a 8,568,795 0
android jsc x86 8,754,733 0
android jsc x86_64 9,331,071 0

Base commit: 25793ea

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Naturalclar in a903d1b.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants