New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overflow:hidden is not supported on Android #3198

Closed
xinthink opened this Issue Oct 2, 2015 · 59 comments

Comments

Projects
None yet
@xinthink
Contributor

xinthink commented Oct 2, 2015

When the parent view (overflow: 'hidden') has borderRadius set, the child view is not clipped to the shape of the parent.

2015-10-02 11 31 06

demo reproducing the issue: https://rnplay.org/apps/69TRrw

@mkonicek mkonicek added the Android label Oct 2, 2015

@astreet

This comment has been minimized.

Show comment
Hide comment
@astreet

astreet Oct 2, 2015

Contributor

Thanks for the report. Unfortunately overflow: hidden is not respected on android (see https://facebook.github.io/react-native/docs/known-issues.html#the-overflow-style-property-defaults-to-hidden-and-cannot-be-changed-on-android). I think @kmagiera has previously posted about the clipping issue for rounded corners and can chime in here.

Contributor

astreet commented Oct 2, 2015

Thanks for the report. Unfortunately overflow: hidden is not respected on android (see https://facebook.github.io/react-native/docs/known-issues.html#the-overflow-style-property-defaults-to-hidden-and-cannot-be-changed-on-android). I think @kmagiera has previously posted about the clipping issue for rounded corners and can chime in here.

@kmagiera

This comment has been minimized.

Show comment
Hide comment
@kmagiera

kmagiera Oct 5, 2015

Contributor

Nothing more to add here. Unfortunately this is a known problem and is not being worked on as mentioned in the docs. Closing this as it's already on the list. If you guys have any proposal on how this could be implemented without causing significant perf issue in rendering pipeline feel free to reopen and post your ideas here

Contributor

kmagiera commented Oct 5, 2015

Nothing more to add here. Unfortunately this is a known problem and is not being worked on as mentioned in the docs. Closing this as it's already on the list. If you guys have any proposal on how this could be implemented without causing significant perf issue in rendering pipeline feel free to reopen and post your ideas here

@kmagiera kmagiera closed this Oct 5, 2015

@rreusser

This comment has been minimized.

Show comment
Hide comment
@rreusser

rreusser Nov 20, 2015

Contributor

We're using imgix, so I think we'll be able to add ?fm=png&mask=ellipse and be on our way. Dodged a bullet there but will encounter moderate problems elsewhere.

I'll submit a PR to note that in addition to hidden always being true, it doesn't obey borderRadius, which is not currently noted in the docs. (I assumed that if hidden were true, it would be clipped by the borderRadius just fine.)

Contributor

rreusser commented Nov 20, 2015

We're using imgix, so I think we'll be able to add ?fm=png&mask=ellipse and be on our way. Dodged a bullet there but will encounter moderate problems elsewhere.

I'll submit a PR to note that in addition to hidden always being true, it doesn't obey borderRadius, which is not currently noted in the docs. (I assumed that if hidden were true, it would be clipped by the borderRadius just fine.)

rreusser added a commit to rreusser/react-native that referenced this issue Nov 20, 2015

rreusser added a commit to rreusser/react-native that referenced this issue Nov 20, 2015

brentvatne added a commit that referenced this issue Nov 25, 2015

Merge pull request #4256 from rreusser/note-on-known-issue-for-3198
[Docs] Additional note for Android borderRadius clipping #3198

sunnylqm added a commit to sunnylqm/react-native that referenced this issue Dec 2, 2015

Crash-- added a commit to Crash--/react-native that referenced this issue Dec 24, 2015

@Kudo

This comment has been minimized.

Show comment
Hide comment
@Kudo

Kudo Jan 20, 2016

Contributor

@kmagiera May I ask where to find the comment or discussion about clipping issue with rounded corners that you posted before?

Contributor

Kudo commented Jan 20, 2016

@kmagiera May I ask where to find the comment or discussion about clipping issue with rounded corners that you posted before?

@kmagiera

This comment has been minimized.

Show comment
Hide comment
Contributor

kmagiera commented Jan 26, 2016

@Kudo

This comment has been minimized.

Show comment
Hide comment
@Kudo

Kudo Jan 27, 2016

Contributor

@kmagiera I see.
The feature is really useful for some cornered UI construction.
Would like to know more detail of your mentioned significant perf drops and see if we can make this feature happens.

Contributor

Kudo commented Jan 27, 2016

@kmagiera I see.
The feature is really useful for some cornered UI construction.
Would like to know more detail of your mentioned significant perf drops and see if we can make this feature happens.

@raymanyoung

This comment has been minimized.

Show comment
Hide comment
@raymanyoung

raymanyoung Mar 24, 2016

More info:
this demo (https://rnplay.org/apps/WlY9aA) shows if the outer control is an image, the borderRadius property will totally not working.

raymanyoung commented Mar 24, 2016

More info:
this demo (https://rnplay.org/apps/WlY9aA) shows if the outer control is an image, the borderRadius property will totally not working.

@astreet

This comment has been minimized.

Show comment
Hide comment
@astreet

astreet Mar 24, 2016

Contributor

We're working on an alternative UI implementation on Android that will fix this -- it's still in testing internally so don't expect it for a few more months, but do know we are working on getting a fix.

Contributor

astreet commented Mar 24, 2016

We're working on an alternative UI implementation on Android that will fix this -- it's still in testing internally so don't expect it for a few more months, but do know we are working on getting a fix.

@dgladkov dgladkov referenced this issue Mar 31, 2016

Closed

Android Support? #3

@viju85

This comment has been minimized.

Show comment
Hide comment
@viju85

viju85 Apr 13, 2016

Any updates on this issue ?

viju85 commented Apr 13, 2016

Any updates on this issue ?

@bsinc

This comment has been minimized.

Show comment
Hide comment
@bsinc

bsinc Apr 14, 2016

I have a fairly cringe-worthy fix using styles that works for me in the meantime. This is a UI for creating group avatars out of user avatars. Similar to Facebook Messengers group avatars.

https://rnplay.org/apps/qXLzlw

bsinc commented Apr 14, 2016

I have a fairly cringe-worthy fix using styles that works for me in the meantime. This is a UI for creating group avatars out of user avatars. Similar to Facebook Messengers group avatars.

https://rnplay.org/apps/qXLzlw

@yonatanmn

This comment has been minimized.

Show comment
Hide comment
@yonatanmn

yonatanmn Apr 25, 2016

@bsinc that's a great solution! thx.
just clarifying what you did:

  <View style={styles.circle}>
            <Image style={styles.image} />
            <View style={styles.fixCircleClipping}/>

          </View>
  circle: {
    width: circleSize,
    height: circleSize,
    borderRadius: circleSize / 2,
    overflow: 'hidden',
  },
  fixCircleClipping: {
    position: 'absolute',
    top: -circleFixBorder,
    bottom: -circleFixBorder,
    right: -circleFixBorder,
    left: -circleFixBorder,
    borderRadius: circleSize / 2 + circleFixBorder / 2,
    borderWidth: circleFixBorder,
    borderColor: bgColor
  },

yonatanmn commented Apr 25, 2016

@bsinc that's a great solution! thx.
just clarifying what you did:

  <View style={styles.circle}>
            <Image style={styles.image} />
            <View style={styles.fixCircleClipping}/>

          </View>
  circle: {
    width: circleSize,
    height: circleSize,
    borderRadius: circleSize / 2,
    overflow: 'hidden',
  },
  fixCircleClipping: {
    position: 'absolute',
    top: -circleFixBorder,
    bottom: -circleFixBorder,
    right: -circleFixBorder,
    left: -circleFixBorder,
    borderRadius: circleSize / 2 + circleFixBorder / 2,
    borderWidth: circleFixBorder,
    borderColor: bgColor
  },
@maikokuppe

This comment has been minimized.

Show comment
Hide comment
@maikokuppe

maikokuppe Jun 6, 2016

@bsinc That's brilliant, thank you!

maikokuppe commented Jun 6, 2016

@bsinc That's brilliant, thank you!

@joypatel04

This comment has been minimized.

Show comment
Hide comment
@joypatel04

joypatel04 Aug 3, 2016

@astreet Is there any updates?
Thanks

joypatel04 commented Aug 3, 2016

@astreet Is there any updates?
Thanks

@msafi

This comment has been minimized.

Show comment
Hide comment
@msafi

msafi Aug 9, 2016

Is this still a known issue? I can't find the known issues page anymore.

msafi commented Aug 9, 2016

Is this still a known issue? I can't find the known issues page anymore.

@Duelsik

This comment has been minimized.

Show comment
Hide comment
@Duelsik

Duelsik Aug 13, 2016

@astreet this will be fixed in 0.32? When 0.32 comes out?

Duelsik commented Aug 13, 2016

@astreet this will be fixed in 0.32? When 0.32 comes out?

@julienvincent

This comment has been minimized.

Show comment
Hide comment
@julienvincent

julienvincent Aug 16, 2016

@Duelsik Was this hinted to being fixed in 0.32 or are you just asking? The release notes for 0.32 do not mention it anywhere.

julienvincent commented Aug 16, 2016

@Duelsik Was this hinted to being fixed in 0.32 or are you just asking? The release notes for 0.32 do not mention it anywhere.

@astreet

This comment has been minimized.

Show comment
Hide comment
@astreet

astreet Aug 23, 2016

Contributor

Hey all, sorry you are being hit by this -- a couple engineers at FB are actively working on open sourcing our internal fix for this, but it's not a simple change so unfortunately it'll take a while longer. Tentatively, they are hoping to have it open sourced by the end of the year.

Contributor

astreet commented Aug 23, 2016

Hey all, sorry you are being hit by this -- a couple engineers at FB are actively working on open sourcing our internal fix for this, but it's not a simple change so unfortunately it'll take a while longer. Tentatively, they are hoping to have it open sourced by the end of the year.

@julienvincent

This comment has been minimized.

Show comment
Hide comment
@julienvincent

julienvincent Aug 23, 2016

@astreet Thanks for the info! I eagerly await the fix!

I wonder if there is some temporary hack I can do with css to imitate this? The fix mentioned by @yonatanmn doesn't cover all cases.

julienvincent commented Aug 23, 2016

@astreet Thanks for the info! I eagerly await the fix!

I wonder if there is some temporary hack I can do with css to imitate this? The fix mentioned by @yonatanmn doesn't cover all cases.

@KristoferEng

This comment has been minimized.

Show comment
Hide comment
@KristoferEng

KristoferEng commented Aug 25, 2016

@bsinc Thank you!

@sscaff1

This comment has been minimized.

Show comment
Hide comment
@sscaff1

sscaff1 Aug 30, 2016

Contributor

I would also be interested in a temporary hack to fix this problem.

Contributor

sscaff1 commented Aug 30, 2016

I would also be interested in a temporary hack to fix this problem.

@KristoferEng

This comment has been minimized.

Show comment
Hide comment
@KristoferEng

KristoferEng Aug 30, 2016

Try bsinc's hack. It worked for me.

KristoferEng commented Aug 30, 2016

Try bsinc's hack. It worked for me.

@sscaff1

This comment has been minimized.

Show comment
Hide comment
@sscaff1

sscaff1 Aug 30, 2016

Contributor

It doesn't work for me because I basically have a grid of circles. So if I use that hack, I get a bunch of circles with the views used to cover the overflow portion over my circles.

Contributor

sscaff1 commented Aug 30, 2016

It doesn't work for me because I basically have a grid of circles. So if I use that hack, I get a bunch of circles with the views used to cover the overflow portion over my circles.

@julienvincent

This comment has been minimized.

Show comment
Hide comment
@julienvincent

julienvincent Jan 24, 2017

I would suggest making a vanilla reproduce repo to demonstrate the problem you are experiencing and then opening an issue.

julienvincent commented Jan 24, 2017

I would suggest making a vanilla reproduce repo to demonstrate the problem you are experiencing and then opening an issue.

@tiempham

This comment has been minimized.

Show comment
Hide comment
@tiempham

tiempham Mar 6, 2017

On RN 0.41.2 you can try to add
import com.facebook.react.uimanager.UIImplementationProvider;
import com.facebook.react.flat.FlatUIImplementationProvider;
and
@override
protected UIImplementationProvider getUIImplementationProvider() {
return new FlatUIImplementationProvider();
}
in ReactNativeHost class.

tiempham commented Mar 6, 2017

On RN 0.41.2 you can try to add
import com.facebook.react.uimanager.UIImplementationProvider;
import com.facebook.react.flat.FlatUIImplementationProvider;
and
@override
protected UIImplementationProvider getUIImplementationProvider() {
return new FlatUIImplementationProvider();
}
in ReactNativeHost class.

@ryanhomer

This comment has been minimized.

Show comment
Hide comment
@ryanhomer

ryanhomer Mar 13, 2017

Since the view is not clipping the child image, I apply a border-radius to my image as well:

<View style={styles.imageContainer}>
  <TouchableOpacity onPress={props.onChangeProfilePhoto}>
    <View style={styles.changeProfileButton}>
      {profile.photo
        ? <Image
          style={styles.image}
          source={{ uri: profile.photo }} />
        : <Icon
          name='person'
          style={{ fontSize: 60 }} />
      }
    </View>
  </TouchableOpacity>
</View>
const styles = StyleSheet.create({
  ...,
  imageContainer: {
      alignItems: 'center',
      justifyContent: 'center',
      backgroundColor: ColorDefaults.background.darkerGrey,
      flex: 0.25,
  },
  image: {
      width: 98,
      height: 98,
      borderRadius: 50,
  },
  changeProfileButton: {
      width: 100,
      height: 100,
      justifyContent: 'center',
      alignItems: 'center',
      borderRadius: 50,
      borderWidth: 2,
  },
  ...,
};

ryanhomer commented Mar 13, 2017

Since the view is not clipping the child image, I apply a border-radius to my image as well:

<View style={styles.imageContainer}>
  <TouchableOpacity onPress={props.onChangeProfilePhoto}>
    <View style={styles.changeProfileButton}>
      {profile.photo
        ? <Image
          style={styles.image}
          source={{ uri: profile.photo }} />
        : <Icon
          name='person'
          style={{ fontSize: 60 }} />
      }
    </View>
  </TouchableOpacity>
</View>
const styles = StyleSheet.create({
  ...,
  imageContainer: {
      alignItems: 'center',
      justifyContent: 'center',
      backgroundColor: ColorDefaults.background.darkerGrey,
      flex: 0.25,
  },
  image: {
      width: 98,
      height: 98,
      borderRadius: 50,
  },
  changeProfileButton: {
      width: 100,
      height: 100,
      justifyContent: 'center',
      alignItems: 'center',
      borderRadius: 50,
      borderWidth: 2,
  },
  ...,
};
@stoffern

This comment has been minimized.

Show comment
Hide comment
@stoffern

stoffern Mar 13, 2017

@ryanhomer it is not a solution.

Please read https://facebook.github.io/react-native/releases/0.26/docs/known-issues.html#the-overflow-style-property-defaults-to-hidden-and-cannot-be-changed-on-android before comming with workaround and solutions to that it is related to the problem itself.

stoffern commented Mar 13, 2017

@ryanhomer it is not a solution.

Please read https://facebook.github.io/react-native/releases/0.26/docs/known-issues.html#the-overflow-style-property-defaults-to-hidden-and-cannot-be-changed-on-android before comming with workaround and solutions to that it is related to the problem itself.

@henrikra

This comment has been minimized.

Show comment
Hide comment
@henrikra

henrikra Apr 2, 2017

Here is my reproduction of the problem: https://snack.expo.io/BkHBr6Vpx

henrikra commented Apr 2, 2017

Here is my reproduction of the problem: https://snack.expo.io/BkHBr6Vpx

@desmond1121

This comment has been minimized.

Show comment
Hide comment
@desmond1121

desmond1121 Apr 7, 2017

Contributor

If just want to clip overflow sub views, you can set removeclippedsubviews to true with overflow: 'hidden' and it would work.

Contributor

desmond1121 commented Apr 7, 2017

If just want to clip overflow sub views, you can set removeclippedsubviews to true with overflow: 'hidden' and it would work.

@henrikra

This comment has been minimized.

Show comment
Hide comment
@henrikra

henrikra Apr 7, 2017

@desmond1121 Can you modify my snack above and show how you can do it with removeclippedsubviews?

henrikra commented Apr 7, 2017

@desmond1121 Can you modify my snack above and show how you can do it with removeclippedsubviews?

@desmond1121

This comment has been minimized.

Show comment
Hide comment
@desmond1121

desmond1121 Apr 10, 2017

Contributor

@henrikra Sorry for my misunderstood, removeClippedSubviews would remove out bound sub views but not clip in bound views.. so definitely it's not work with your problem.

Contributor

desmond1121 commented Apr 10, 2017

@henrikra Sorry for my misunderstood, removeClippedSubviews would remove out bound sub views but not clip in bound views.. so definitely it's not work with your problem.

@PARAGJYOTI

This comment has been minimized.

Show comment
Hide comment
@PARAGJYOTI

PARAGJYOTI Apr 13, 2017

@bsinc it's so smart . Just wanted to add a little advice , never use borderRadius as props (i repeat props , not style) in Image , like

     <Image source={some source} borderRadius={50} /> .

   Just Never !!

Using in scrollview will crash the app on repeated scrolling , and you will ruin the day finding where the bug is , even debugger won't tell you whats wrong . Its may be a out of memory problem . If its not within ScrollView or ListView (not sure), its fine . I almost ruined 4 hours finding the bug . Use the @bsinc trick instead .

PARAGJYOTI commented Apr 13, 2017

@bsinc it's so smart . Just wanted to add a little advice , never use borderRadius as props (i repeat props , not style) in Image , like

     <Image source={some source} borderRadius={50} /> .

   Just Never !!

Using in scrollview will crash the app on repeated scrolling , and you will ruin the day finding where the bug is , even debugger won't tell you whats wrong . Its may be a out of memory problem . If its not within ScrollView or ListView (not sure), its fine . I almost ruined 4 hours finding the bug . Use the @bsinc trick instead .

@kesha-antonov

This comment has been minimized.

Show comment
Hide comment
@kesha-antonov

kesha-antonov Apr 18, 2017

+1 for this to have on android

kesha-antonov commented Apr 18, 2017

+1 for this to have on android

@mica16

This comment has been minimized.

Show comment
Hide comment
@mica16

mica16 commented May 3, 2017

+1

@madjam002

This comment has been minimized.

Show comment
Hide comment
@madjam002

madjam002 May 3, 2017

Please upvote on product pains (https://react-native.canny.io/feature-requests/p/add-overflow-support-to-android) or upvote this issue rather than spamming "+1" comments.

@mica16 @diegorodriguesvieira

madjam002 commented May 3, 2017

Please upvote on product pains (https://react-native.canny.io/feature-requests/p/add-overflow-support-to-android) or upvote this issue rather than spamming "+1" comments.

@mica16 @diegorodriguesvieira

@miyamatthild

This comment has been minimized.

Show comment
Hide comment
@miyamatthild

miyamatthild May 6, 2017

I'd just like to throw in another data point for setting zIndex as a workaround (from @saberking's post). I'm working with sprite sheets and ran into the issue where the entire sprite sheet was being shown on Android (worked fine for iOS).

render() {
  return (
    <View style={styles.container}>
      <View style={styles.imageWrapper}>
        <Image
          style={styles.image}
          source={{uri: [...]}}
        />
      </View>
      <Text style={styles.text}>Without zIndex: 1</Text>
      <View style={styles.imageWrapper2}>
        <Image
          style={styles.image}
          source={{uri: [...]}}
        />
      </View>
      <Text style={styles.text}>With zIndex: 1</Text>
    </View>
  );
}

var styles = StyleSheet.create({
  container: {
    backgroundColor: '#f9f8f5',
    flex: 1,
    padding: 20,
    alignItems: 'center'
  },
  imageWrapper: {
    overflow: 'hidden',
    width: 86,
    height: 86
  },
  imageWrapper2: {
    overflow: 'hidden',
    width: 86,
    height: 86,
    zIndex: 1
  },
  image: {
    width: 196,
    height: 86
  },
  text: {
    paddingTop: 10,
    paddingBottom: 30
  }
});

This will render:

zindex

Verified on a Nexus 5 with Android 7.0. Note that you don't need to specify as high a value as 100. Specifying a zIndex of 1 was sufficient to solve the issue for me.

miyamatthild commented May 6, 2017

I'd just like to throw in another data point for setting zIndex as a workaround (from @saberking's post). I'm working with sprite sheets and ran into the issue where the entire sprite sheet was being shown on Android (worked fine for iOS).

render() {
  return (
    <View style={styles.container}>
      <View style={styles.imageWrapper}>
        <Image
          style={styles.image}
          source={{uri: [...]}}
        />
      </View>
      <Text style={styles.text}>Without zIndex: 1</Text>
      <View style={styles.imageWrapper2}>
        <Image
          style={styles.image}
          source={{uri: [...]}}
        />
      </View>
      <Text style={styles.text}>With zIndex: 1</Text>
    </View>
  );
}

var styles = StyleSheet.create({
  container: {
    backgroundColor: '#f9f8f5',
    flex: 1,
    padding: 20,
    alignItems: 'center'
  },
  imageWrapper: {
    overflow: 'hidden',
    width: 86,
    height: 86
  },
  imageWrapper2: {
    overflow: 'hidden',
    width: 86,
    height: 86,
    zIndex: 1
  },
  image: {
    width: 196,
    height: 86
  },
  text: {
    paddingTop: 10,
    paddingBottom: 30
  }
});

This will render:

zindex

Verified on a Nexus 5 with Android 7.0. Note that you don't need to specify as high a value as 100. Specifying a zIndex of 1 was sufficient to solve the issue for me.

@luco

This comment has been minimized.

Show comment
Hide comment
@luco

luco May 8, 2017

Any update?

This is a must have. Much of UI nowadays is based on rounded corners with subclipping.

luco commented May 8, 2017

Any update?

This is a must have. Much of UI nowadays is based on rounded corners with subclipping.

@hughnguy

This comment has been minimized.

Show comment
Hide comment
@hughnguy

hughnguy May 13, 2017

Temporary workaround is positioning multiple "absolute" views with a solid border color on top of the image (using z-index) to fill in the gaps. Works if your background is a solid color.

radius

<View style={{height:215, alignItems:'center', flex:1}}>
    <View style={{position:'absolute', height:215, width:deviceWidth*0.95, borderWidth:10, borderRadius: 5, borderColor:'white'}}></View>
    <View style={{position:'absolute', height:215, width:deviceWidth*0.95, borderWidth:10, borderRadius: 20, borderColor:'white'}}></View>
    <Image
        resizeMode="cover"
        style={{height:215, width:deviceWidth*0.9, zIndex:-1}}
        source={this.props.image}
    />
</View>

hughnguy commented May 13, 2017

Temporary workaround is positioning multiple "absolute" views with a solid border color on top of the image (using z-index) to fill in the gaps. Works if your background is a solid color.

radius

<View style={{height:215, alignItems:'center', flex:1}}>
    <View style={{position:'absolute', height:215, width:deviceWidth*0.95, borderWidth:10, borderRadius: 5, borderColor:'white'}}></View>
    <View style={{position:'absolute', height:215, width:deviceWidth*0.95, borderWidth:10, borderRadius: 20, borderColor:'white'}}></View>
    <Image
        resizeMode="cover"
        style={{height:215, width:deviceWidth*0.9, zIndex:-1}}
        source={this.props.image}
    />
</View>

@PARAGJYOTI

This comment has been minimized.

Show comment
Hide comment
@PARAGJYOTI

PARAGJYOTI May 13, 2017

Yesterday I suddenly discoveree a simple solution . Just added backgroundColor in Image style and added borderRadius and it worked liked magic. Tried it on android . May be works on IOS too

PARAGJYOTI commented May 13, 2017

Yesterday I suddenly discoveree a simple solution . Just added backgroundColor in Image style and added borderRadius and it worked liked magic. Tried it on android . May be works on IOS too

@wollld

This comment has been minimized.

Show comment
Hide comment
@wollld

wollld May 16, 2017

@yonatanmn if borderRadius is 5?

wollld commented May 16, 2017

@yonatanmn if borderRadius is 5?

@stoffern

This comment has been minimized.

Show comment
Hide comment
@stoffern

stoffern May 16, 2017

@PARAGJYOTI this is not a solution. look at #3198 (comment) you are refering to the same workaround.

stoffern commented May 16, 2017

@PARAGJYOTI this is not a solution. look at #3198 (comment) you are refering to the same workaround.

@julienvincent

This comment has been minimized.

Show comment
Hide comment
@julienvincent

julienvincent May 16, 2017

There isn't much more to be said in regard to this issue. Could we please lock conversations on this thread until further development?

julienvincent commented May 16, 2017

There isn't much more to be said in regard to this issue. Could we please lock conversations on this thread until further development?

@yonatanmn

This comment has been minimized.

Show comment
Hide comment
@yonatanmn

yonatanmn May 17, 2017

@wollld - what about it? should work as far as I see

yonatanmn commented May 17, 2017

@wollld - what about it? should work as far as I see

@yasserzubair

This comment has been minimized.

Show comment
Hide comment
@yasserzubair

yasserzubair commented May 18, 2017

+1

@EdmundMai

This comment has been minimized.

Show comment
Hide comment
@EdmundMai

EdmundMai commented May 18, 2017

+1

@stoffern

This comment has been minimized.

Show comment
Hide comment
@stoffern

stoffern May 18, 2017

Please....
Stop +1 ... Upvote it here: https://react-native.canny.io/feature-requests instead.
Stop spaming workarounds, they dont solve the issue, feel free to create a PR to fix it instead.

Could we please lock the conversation until the issue is solved or there exists a PR to solve it?
@astreet @hramos

stoffern commented May 18, 2017

Please....
Stop +1 ... Upvote it here: https://react-native.canny.io/feature-requests instead.
Stop spaming workarounds, they dont solve the issue, feel free to create a PR to fix it instead.

Could we please lock the conversation until the issue is solved or there exists a PR to solve it?
@astreet @hramos

@facebook facebook locked and limited conversation to collaborators May 18, 2017

@hramos hramos changed the title from [Android] Overflow:hidden not work properly to overflow:hidden is not supported on Android Jun 1, 2017

@hramos

This comment has been minimized.

Show comment
Hide comment
@hramos

hramos Aug 16, 2017

Contributor

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

Contributor

hramos commented Aug 16, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Aug 16, 2017

@hramos hramos closed this Aug 16, 2017

@hramos hramos reopened this Sep 5, 2017

@AaaChiuuu

This comment has been minimized.

Show comment
Hide comment
@AaaChiuuu

AaaChiuuu Sep 30, 2017

Contributor

This is fixed with D5917111.

Contributor

AaaChiuuu commented Sep 30, 2017

This is fixed with D5917111.

@AaaChiuuu AaaChiuuu closed this Sep 30, 2017

@AaaChiuuu AaaChiuuu self-assigned this Sep 30, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.