Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCTAppSetupPrepareApp breaks Flipper support on iOS #33497

Closed
oblador opened this issue Mar 25, 2022 · 1 comment
Closed

RCTAppSetupPrepareApp breaks Flipper support on iOS #33497

oblador opened this issue Mar 25, 2022 · 1 comment
Assignees
@cipolleschi
Labels
Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Needs: Attention Issues where the author has responded to feedback. Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Tool: Flipper

Comments

@oblador
Copy link
Contributor

oblador commented Mar 25, 2022

Description

In the latest RCs of RN 0.68.0 (tried 2 & 3) Flipper setup has moved into the RCTAppSetupPrepareApp helper. This effectively breaks integration as in this file FB_SONARKIT_ENABLED is not defined nor is the Flipper dependencies available as they are not listed in the React-Core podspec.

Copy-pasting the setup into the AppDelegate as it works in 0.67 and below restores the functionality.

Version

0.68.0-RC.3

Output of npx react-native info

System:
    OS: macOS 12.3
    CPU: (8) arm64 Apple M1
    Memory: 142.73 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.2 - ~/.volta/tools/image/node/16.14.2/bin/node
    Yarn: 1.22.17 - /opt/homebrew/bin/yarn
    npm: 8.5.0 - ~/.volta/tools/image/node/16.14.2/bin/npm
    Watchman: 2022.02.14.00 - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.11.2 - /Users/joel.arvidsson/.asdf/shims/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK:
      API Levels: 30, 31, 32
      Build Tools: 30.0.2, 31.0.0, 32.0.0, 32.1.0
      System Images: android-30 | Google APIs ARM 64 v8a, android-32 | Google APIs ARM 64 v8a
      Android NDK: Not Found
  IDEs:
    Android Studio: 2021.1 AI-211.7628.21.2111.8193401
    Xcode: 13.3/13E113 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.11 - /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2 
    react-native: 0.68.0-rc.3 => 0.68.0-rc.3 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce

npx react-native init FlipperReproduction --version 0.68.0-rc.3
cd FlipperReproduction
yarn ios
open /Applications/Flipper.app # 0.140.0, but 0.125.0 is the same

Observe no application selectable:
Screenshot 2022-03-25 at 09 40 11

Snack, code example, screenshot, or link to a repository

No response
@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Mar 25, 2022
@cortinico cortinico added Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Needs: Attention Issues where the author has responded to feedback. Tool: Flipper Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. and removed Needs: Triage 🔍 labels Mar 25, 2022
@cipolleschi cipolleschi self-assigned this Mar 25, 2022
@cipolleschi cipolleschi mentioned this issue Mar 25, 2022
Closed
cipolleschi pushed a commit to cipolleschi/react-native that referenced this issue Mar 25, 2022
@facebook-github-bot
Enable SonarKit and Flipper in React-Core
301234c 
Summary:
This DIFF turns on the `FB_SONARKIT_ENABLED` flag when installing Flipper ina RN app. The flag is enabled only in Debug config, given that Flipper is installed only in this configuration.

This PR also fixes this issue: facebook#33497

## Changelog
[iOS][Changed] - Enable SonarKit in React-Core when the configuration is `'Debug'`

Differential Revision: D35141506

fbshipit-source-id: 019bab85d60b2b02ac50fcc82de7879833653505
facebook-github-bot pushed a commit that referenced this issue Mar 25, 2022
@facebook-github-bot
Enable SonarKit and Flipper in React-Core (#33499)
b5343a6 
Summary:
Pull Request resolved: #33499

This DIFF turns on the `FB_SONARKIT_ENABLED` flag when installing Flipper ina RN app. The flag is enabled only in Debug config, given that Flipper is installed only in this configuration.

This PR also fixes this issue: #33497

This PR is required because release 0.67 has the Flag in the app, while release 0.68 moved it in the React-Core pod.
We can't enable the flag at the `React-Core.podspec` level because we should not make assumptions on whether users want flipper or not.

## Changelog
[iOS][Changed] - Enable SonarKit in React-Core when the configuration is `'Debug'`

Reviewed By: cortinico

Differential Revision: D35141506

fbshipit-source-id: 171b7fa8ea7727c633ef963408e86b332c32e9fa
ShikaSD pushed a commit that referenced this issue Mar 25, 2022
Enable SonarKit and Flipper in React-Core (#33499)
e645629 
Summary:
Pull Request resolved: #33499

This DIFF turns on the `FB_SONARKIT_ENABLED` flag when installing Flipper ina RN app. The flag is enabled only in Debug config, given that Flipper is installed only in this configuration.

This PR also fixes this issue: #33497

This PR is required because release 0.67 has the Flag in the app, while release 0.68 moved it in the React-Core pod.
We can't enable the flag at the `React-Core.podspec` level because we should not make assumptions on whether users want flipper or not.

## Changelog
[iOS][Changed] - Enable SonarKit in React-Core when the configuration is `'Debug'`

Reviewed By: cortinico

Differential Revision: D35141506

fbshipit-source-id: 171b7fa8ea7727c633ef963408e86b332c32e9fa
douglowder pushed a commit to react-native-tvos/react-native-tvos that referenced this issue Mar 25, 2022
@douglowder
Enable SonarKit and Flipper in React-Core (#33499)
46b685e 
Summary:
Pull Request resolved: facebook/react-native#33499

This DIFF turns on the `FB_SONARKIT_ENABLED` flag when installing Flipper ina RN app. The flag is enabled only in Debug config, given that Flipper is installed only in this configuration.

This PR also fixes this issue: facebook/react-native#33497

This PR is required because release 0.67 has the Flag in the app, while release 0.68 moved it in the React-Core pod.
We can't enable the flag at the `React-Core.podspec` level because we should not make assumptions on whether users want flipper or not.

## Changelog
[iOS][Changed] - Enable SonarKit in React-Core when the configuration is `'Debug'`

Reviewed By: cortinico

Differential Revision: D35141506

fbshipit-source-id: 171b7fa8ea7727c633ef963408e86b332c32e9fa
@oblador
Copy link
Contributor Author

oblador commented Mar 30, 2022

Resolved in 0.68.0-rc.4 👍

@oblador oblador closed this as completed Mar 30, 2022
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this issue Jan 15, 2023
@Saadnajmi
Enable SonarKit and Flipper in React-Core (facebook#33499)
b9af5b9 
Summary:
Pull Request resolved: facebook#33499

This DIFF turns on the `FB_SONARKIT_ENABLED` flag when installing Flipper ina RN app. The flag is enabled only in Debug config, given that Flipper is installed only in this configuration.

This PR also fixes this issue: facebook#33497

This PR is required because release 0.67 has the Flag in the app, while release 0.68 moved it in the React-Core pod.
We can't enable the flag at the `React-Core.podspec` level because we should not make assumptions on whether users want flipper or not.

## Changelog
[iOS][Changed] - Enable SonarKit in React-Core when the configuration is `'Debug'`

Reviewed By: cortinico

Differential Revision: D35141506

fbshipit-source-id: 171b7fa8ea7727c633ef963408e86b332c32e9fa
@facebook facebook locked as resolved and limited conversation to collaborators Mar 30, 2023
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cipolleschi cipolleschi

Labels
Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Needs: Attention Issues where the author has responded to feedback. Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Tool: Flipper
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oblador @cortinico @cipolleschi @react-native-bot