Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresco 2.6 - React native app upgrade showing icons misplaced in android #33798

Open
Sinson48 opened this issue May 10, 2022 · 18 comments
Open
Labels
Impact: Bug The issue represents a bug somewhere Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Needs: Task This issue has been triaged but it does not have an associated task Platform: Android Android applications. Priority: Low Tech: React Native Core Issue related to the Core of React Native Type: Old Architecture For issues related to the old architecture

Comments

@Sinson48
Copy link

Description

We are developing a react-native application. When we uploaded the new version of the current play store app and tried to update the app which is already on the device, then some of the icons are misplaced and it showed the other sections of the app in ANDROID. This is really strange for us. When I deleted the app and reinstall the application it will be fine. But when updating the app the icons are placed somewhere in the app on Android.

Also in iOS, there are no such issues.
In the earlier versions, everything was fine in android and it showed weird results on some of the icons while updating the new version.

example:- If I place an icon named "cart" it's supposed to show a cart icon, but instead I'm getting a chat icon. But these icons are what we are showing from the assets folder. The issue is like this link:- (#29645)

Version

0.66.3

Output of npx react-native info

System:
OS: macOS 12.1
CPU: (8) x64 Apple M1
Memory: 27.16 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 17.4.0 - /usr/local/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 8.3.1 - /usr/local/bin/npm
Watchman: 2022.01.24.00 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK:
API Levels: 23, 28, 29, 30, 31, 32
Build Tools: 29.0.2, 30.0.2, 30.0.3, 31.0.0, 32.0.0
System Images: android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom, android-30 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom, android-31 | Google APIs ARM 64 v8a, android-32 | Google APIs ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2021.1 AI-211.7628.21.2111.8139111
Xcode: 13.3.1/13E500a - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_292 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.66.3 => 0.66.3
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found

Steps to reproduce

When we tried to update the app which is already on the device, then some of the icons are misplaced and it showed the other sections of the app in ANDROID.
But once re-install there is no issue remains.

Snack, code example, screenshot, or link to a repository

Screen Shot 2022-05-10 at 1 39 41 PM

Search icon showing here instead of a save-card icon.

@react-native-bot react-native-bot added the Platform: Android Android applications. label May 10, 2022
@cipolleschi cipolleschi added Priority: Low Tech: React Native Core Issue related to the Core of React Native Type: Old Architecture For issues related to the old architecture Impact: Bug The issue represents a bug somewhere Needs: Task This issue has been triaged but it does not have an associated task and removed Needs: Triage 🔍 labels May 17, 2022
@purut18
Copy link

purut18 commented Jun 8, 2022

Hi, did you find a solution for this? We're facing this with images

@mohdmunaf
Copy link

We are also seeing this issue. Anyone found solution?
@purut18

@cuiken
Copy link

cuiken commented Jul 19, 2022

same issue

@mohdmunaf
Copy link

@cuiken @purut18 I have found a temporary solution. This issue gets resolved if we clear the cache of the app. So I am programmatically clearing the cache after the app gets updated from playstore.

@cuiken Have you enabled Hermes?

@mohdmunaf
Copy link

Native code snippet for you to bridge.

  @ReactMethod
  public void clearAppCache() {
    try {
      File dir = this.getReactApplicationContext().getCacheDir();
      deleteDir(dir);
    } catch (Exception e) { e.printStackTrace();}
  }

@cuiken
Copy link

cuiken commented Jul 20, 2022

enabled Hermes

no, im not

@nikunj1314
Copy link

nikunj1314 commented Sep 23, 2022

did anyone find the solution for this issue? I am facing same issue in android after updating app from play store.
All images and icons are messed up!

Screenshot_20220923_201201_Jackett

@mohdmunaf
Copy link

@nikunj1314 I have mentioned the solution above.
#33798 (comment)

@KiranRadish
Copy link

I got same issue in production today.
has anyone got solution for this?? One thing i noticed is after uninstalling old version and reinstalling new version from play store it works fine (i.e Inside app icon shows properly)

@KiranRadish
Copy link

@mohdmunaf could you please elaborate your solution?

@pandiyanmadhan
Copy link

@mohdmunaf Where i need to update below code
@ReactMethod
public void clearAppCache() {
try {
File dir = this.getReactApplicationContext().getCacheDir();
deleteDir(dir);
} catch (Exception e) { e.printStackTrace();}
}

@KiranRadish
Copy link

@pandiyanmadhan use this
in android/app/build.gradle
implementation 'com.facebook.fresco:animated-gif:2.5.0'

clear project uninstall app and run again.

this issue is causing with 2.6.0. version of fresco

let me know if this work for you

@kashan20
Copy link

Same issue

@github-actions github-actions bot added the Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. label Jul 21, 2023
@kashan20
Copy link

@pandiyanmadhan use this in android/app/build.gradle implementation 'com.facebook.fresco:animated-gif:2.5.0'

clear project uninstall app and run again.

this issue is causing with 2.6.0. version of fresco

let me know if this work for you

i think you are right i also see this issue
facebook/fresco#2667

@cortinico cortinico changed the title React native app upgrade showing icons misplaced in android Fresco 2.6 - React native app upgrade showing icons misplaced in android Jul 26, 2023
@github-actions
Copy link

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

@somasekharkakarla
Copy link

icon misplace happening on update on existing app. This issue is only happening on update. Not in fresh installation

@nguyentuanit97
Copy link

Up

@lshuyan
Copy link

lshuyan commented Jan 17, 2024

Up, I haved same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: Bug The issue represents a bug somewhere Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Needs: Task This issue has been triaged but it does not have an associated task Platform: Android Android applications. Priority: Low Tech: React Native Core Issue related to the Core of React Native Type: Old Architecture For issues related to the old architecture
Projects
None yet
Development

No branches or pull requests