New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android crashing RN (0.69.4) libhermes-executor-release.so #34686
Comments
Thats because hermes is missing in those variants. Pleasse share your whole build.gradle |
Hey @danilobuerger
|
My guess is that its related to the change here: 4d91f40 react-native/template/android/app/build.gradle Lines 274 to 276 in 743d070
and could just add a new line for each variant, for example:
Maybe @cortinico knows more how to handle other build variants with the new directive? |
@danilobuerger Yeah that's what I thought as well, but then I read this:
|
As far as I understand that should work with https://developer.android.com/studio/build/build-variants#variant_aware |
I have the same issue |
I'm wondering now is it possible that in my case it's looking for |
The way that hermes gets bundled changed in rn 0.70, could you please try with that release? |
Unfortunately I cannot upgrade to rn 0.70 as I'm on expo SDK 46 which would not support 0.70 if I update manually as far as I know. |
Might be related to this issue #33177 (comment) |
I have noticed that (using the template provided by rn team) i get these weird logs:
The weird thing is that i'm building in release mode but i see that for example the app is trying to access |
@Summys yep #33177 (comment) this helped me. Variants have to be named with Release suffix. ( |
That doesn't sound like a proper solution. |
I agree. Specially because docs say it can be named |
The problem here is in the logic in place to remove the You should be able to solve this by specifying a custom project.ext.react = [
bundleInStaging: true,
devDisabledInStaging: true,
enableHermes: true, // clean and rebuild if changing
+ deleteDebugFilesForVariant: {
+ def variant -> variant.name.toLowerCase().contains("release") || variant.name.toLowerCase().contains("canary") ||
variant.name.toLowerCase().contains("beta")
+ }
] We're looking into potentially changing this approach in the future as it's really brittle. |
@danilobuerger the fix, in the end, seems to be the same... |
@danilobuerger Yes it works but I had to add additional lines as well:
|
@mrados7 we have a |
I tried this but I still get the same error. I only have debug and release variants. Anything I am missing? |
I'll be closing this one as this and other issues, have all been solved in 0.71. Please consider upgrading and re-open a new issue if it persists on 0.71 |
Description
I updated to react-native
0.69.4
. Now Android is crashing but only for certain variant types. I have 4 of them (debug
,canary
,beta
andrelease
).debug
andrelease
work fine butcanary
andbeta
give the following error on application startup. Maybe work mentioning is that I useexpo-modules-core
if that makes any difference.Version
0.69.4
Output of
npx react-native info
Steps to reproduce
hermes ->
enabled
build.gradle
Snack, code example, screenshot, or link to a repository
.
The text was updated successfully, but these errors were encountered: