New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android release bundle is not generated in the correct location on RN 0.71.0-rc.0 #35398
Comments
After a quick investigation, deleting this line makes the bundle to be generated in the right location again:
|
I don't understand what's the bug here. Images are missing, which is another bug we're looking into #35439. But what should be fixed here? |
I work on the Datadog SDK, which provide an error tracking system. We use the bundle for adding more context to errors in Datadog, in addition to the sourcemaps. If the location changes it's not so much of an issue for us, I wanted to raise this to get confirmation that this is indeed going to change before making the change on our side, and in case there was some bug hidden behind it. |
I'll close this issue, as it seems there is no hidden bug behind it :) |
Nope the change was intended. We now use the Artifacts API of AGP so we don't have to "hardcode" paths around anymore. As AGP changes paths, we won't be affected by future breakages. |
I am upload js bundle to Sentry manually. I have no idea this is a correct fix. |
Hi @mym0404, This is indeed the correct fix from our conversation ahead. |
I will remember it. Thank you for response 👍🏻 |
Description
When building for release on Android (
yarn android --variant=release
), the bundle file is located atandroid/app/build/ASSETS/createBundleReleaseJsAndAssets/index.android.bundle
, which is a change from the previous location ofandroid/app/build/generated/assets/react/Release/index.android.bundle
.The
android/app/build/generated
does not contain anassets
directory anymore.By looking at the gradle-plugin code, I'm assuming it's not supposed to have changed.
Version
0.71.0-rc.0
Output of
npx react-native info
Steps to reproduce
npx react-native init <YourAppName> --version 0.71.0-rc.0
maven-local.zip
on a folder on your disk.REACT_NATIVE_MAVEN_LOCAL_REPO=<path_to_the_maven-local_unzipped_folder>
setting to the android/gradle.properties fileyarn android --variant=release
Snack, code example, screenshot, or link to a repository
Screenshot of the
android
folder directory after a build:The text was updated successfully, but these errors were encountered: