Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RN [refactor]: bump and realign package versions by running a single … #36573

Merged
merged 1 commit into from Mar 31, 2023
Merged

RN [refactor]: bump and realign package versions by running a single … #36573

merged 1 commit into from Mar 31, 2023

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Mar 22, 2023

See #36568

Opening this PR to check if this will work as expected on *-stable release branches. Once validated and merged, will update wikis accordingly

@hoxyq hoxyq requested a review from kelset March 22, 2023 15:21
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 22, 2023
@github-actions
Copy link

github-actions bot commented Mar 22, 2023 •
edited

Fails
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a469927

@analysis-bot
Copy link

analysis-bot commented Mar 22, 2023 •
edited

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,543,017 -25,396
android hermes armeabi-v7a 7,858,618 -24,169
android hermes x86 9,023,421 -26,898
android hermes x86_64 8,878,520 -26,844
android jsc arm64-v8a 9,142,999 -24,008
android jsc armeabi-v7a 8,334,663 -22,741
android jsc x86 9,198,157 -25,517
android jsc x86_64 9,456,010 -25,528

Base commit: 606946d
Branch: main

@hoxyq
RN [refactor]: bump and realign package versions by running a single …
a469927 
…script

Summary:
Changelog: [Internal]

Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`

The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)

This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully

Differential Revision: D44261057

fbshipit-source-id: 6095209c8183f6d84e2697fda2e9a21f8a57f73e
@hoxyq hoxyq force-pushed the hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable branch from 1d377e2 to a469927 Compare March 31, 2023 12:45
@hoxyq hoxyq merged commit 68cd44b into facebook:0.72-stable Mar 31, 2023
1 of 3 checks passed
@hoxyq hoxyq deleted the hoxyq/cherry-pick-ci-scripts-changes-to-0.72-stable branch March 31, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

@kelset kelset Awaiting requested review from kelset

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hoxyq @analysis-bot @cortinico @facebook-github-bot