RN [refactor]: bump and realign package versions by running a single script#36568
Closed
hoxyq wants to merge 1 commit into
Closed
RN [refactor]: bump and realign package versions by running a single script#36568hoxyq wants to merge 1 commit into
hoxyq wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44261057 |
Base commit: 92b8981 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44261057 |
cipolleschi
approved these changes
Mar 27, 2023
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
These looks good to me!
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44261057 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44261057 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44261057 |
…script (facebook#36568) Summary: Pull Request resolved: facebook#36568 Changelog: [Internal] Okay, so before the monorepo migration we had to use two scripts separately: 1. Bumping every package with `npm run bump-all-updated-packages` 2. Aligning other packages versions with `npm run align-package-versions` The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it) This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully Reviewed By: cortinico, cipolleschi Differential Revision: D44261057 fbshipit-source-id: 277cdc56e58dd890c3323d22e9b3702da069032d
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44261057 |
Contributor
|
This pull request has been merged in 04df252. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
Summary: While working on a couple things, me Riccardo and Nicola noticed that in main for some reason the old `align-package-versions` command in the root package.json was still there in main branch. This was "merged into" `bump-all-updated-packages` by hoxyq all the way back in March; here's the commit for 0.72 branch -> a469927 We are not sure why, but for some reason the same commit in main was borked in some way, and didn't actually remove the command: PR (#36568) and commit (04df252) So this commit just takes care of that. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [INTERNAL] [REMOVED] - remove old command for align packages versions Pull Request resolved: #38548 Test Plan: N/A - it's a removal Reviewed By: cipolleschi Differential Revision: D47669016 Pulled By: cortinico fbshipit-source-id: aa651b69433171219dbc235d947ceed4f88b602a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
npm run bump-all-updated-packagesnpm run align-package-versionsThe reason for it is that before the monorepo in a release branch cutoff process we had a step, which was removing
workspaceskeyword fromreact-nativepackage. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Differential Revision: D44261057
Demo:
Untitled.mov