Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly declare runtime dependencies #41444

Merged
merged 1 commit into from Nov 27, 2023
Merged

Correctly declare runtime dependencies #41444

merged 1 commit into from Nov 27, 2023

Conversation

tido64
Copy link
Collaborator

@tido64 tido64 commented Nov 13, 2023

Summary:

In pnpm setups, codegen will fail during build because it cannot find its dependencies. Some of the dependencies it relies on at runtime are currently declared under devDependencies. This change moves them to dependencies.

Cherry-picks c58e19e.

Changelog:

[GENERAL] [FIXED] - Fix react-native/codegen not being able to resolve dependencies in pnpm setups

Test Plan:

We are currently trying to enable pnpm mode in rnx-kit and hit this issue. We've patched this package locally and it works.

@tido64
Correctly declare runtime dependencies
4bc11a2 
In pnpm setups, codegen will fail during build because it cannot find
its dependencies. Some of the dependencies it relies on at runtime are
currently declared under `devDependencies`. This change moves them to
`dependencies`.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Nov 13, 2023
@tido64 tido64 mentioned this pull request Nov 13, 2023
Merged
10 tasks
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,518,636 -9,130,707
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,756,800 -11,276,603
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d7fd83e
Branch: main

@tido64 tido64 mentioned this pull request Nov 14, 2023
Closed
31 tasks
@huntie huntie merged commit c32064c into 0.73-stable Nov 27, 2023
64 checks passed
@tido64 tido64 deleted the tido/0.73/codegen-npm-dependencies branch November 27, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunaleaps lunaleaps Awaiting requested review from lunaleaps

@fortmarek fortmarek Awaiting requested review from fortmarek

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tido64 @analysis-bot @huntie @facebook-github-bot