Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assetRoots argument is never considered #4388

Closed
jpapillon opened this issue Nov 27, 2015 · 1 comment
Closed

assetRoots argument is never considered #4388

jpapillon opened this issue Nov 27, 2015 · 1 comment
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.

Comments

@jpapillon
Copy link

Setting assetRoots argument for 'react-native start' doesn't change a thing. This is due to these lines in 'local-cli/server/server.js':

args.assetRoots = args.assetRoots
    ? argToArray(args.projectRoots).map(dir =>
      path.resolve(process.cwd(), dir)
    )
    : config.getAssetRoots();

It's using args.projectRoots instead of args.assetRoots on second line.

@facebook-github-bot
Copy link
Contributor

Hey jpapillon, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

  • If this is a feature request or a bug that you would like to be fixed by the team, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
  • If you don't know how to do something or not sure whether some behavior is expected or a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
  • We welcome clear issues and PRs that are ready for in-depth discussion; thank you for your contributions!

@satya164 satya164 added Packager Good first issue Interested in collaborating? Take a stab at fixing one of these issues. labels Nov 29, 2015
christopherdro added a commit to christopherdro/react-native that referenced this issue Nov 30, 2015
@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants