-
Notifications
You must be signed in to change notification settings - Fork 24.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement defaultSource for Image on Android #5158
![:octocat: :octocat:](https://github.githubassets.com/images/icons/emoji/octocat.png)
Comments
![:octocat: :octocat:](https://github.githubassets.com/images/icons/emoji/octocat.png)
Hey brentvatne, thanks for reporting this issue! React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.
|
@nicklockwood Do we want the defaultSource property to be implemented on Android as well? We need some mechanism to handle fallback images on Android. I could give it a shot if wanted. |
@kristjanmik we're still discussing it. I'm not sure if it's needed on iOS since you can implement the same functionality with the onLoad event, but apparently that doesn't work correctly on Android? If you do decided to implement it, I believe the intended (but currently broken) behavior on iOS is that it should appear when the image first starts loading, and disappear when it's replaced by the correct image. If the image never loads, or loads with an error, it will stay indefinitely. |
Hi there! This issue is being closed because it has been inactive for a while. But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/implement-defaultsource-for-image-on-android ProductPains helps the community prioritize the most important issues thanks to its voting feature. Also, if this issue is a bug, please consider sending a pull request with a fix. |
![:octocat: :octocat:](https://github.githubassets.com/images/icons/emoji/octocat.png)
Background: #5074 (comment)
The text was updated successfully, but these errors were encountered: