Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement defaultSource for Image on Android #5158

Closed
brentvatne opened this issue Jan 6, 2016 · 4 comments
Closed

Implement defaultSource for Image on Android #5158

brentvatne opened this issue Jan 6, 2016 · 4 comments
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.

Comments

@brentvatne
Copy link
Collaborator

Background: #5074 (comment)

@brentvatne brentvatne added Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Android Help Wanted :octocat: Issues ideal for external contributors. labels Jan 6, 2016
@facebook-github-bot
Copy link
Contributor

Hey brentvatne, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

  • If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
  • If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
  • We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!

@kristjanmik
Copy link

@nicklockwood Do we want the defaultSource property to be implemented on Android as well? We need some mechanism to handle fallback images on Android. I could give it a shot if wanted.

@nicklockwood
Copy link
Contributor

@kristjanmik we're still discussing it. I'm not sure if it's needed on iOS since you can implement the same functionality with the onLoad event, but apparently that doesn't work correctly on Android?

If you do decided to implement it, I believe the intended (but currently broken) behavior on iOS is that it should appear when the image first starts loading, and disappear when it's replaced by the correct image. If the image never loads, or loads with an error, it will stay indefinitely.

@mkonicek
Copy link
Contributor

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/implement-defaultsource-for-image-on-android

ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub. GitHub issues have voting too, nevertheless
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top

Also, if this issue is a bug, please consider sending a pull request with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants