Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UIExplorer] Add defaultSource / loadingIndicatorSource #5074

Closed
wants to merge 1 commit into from
Closed

[UIExplorer] Add defaultSource / loadingIndicatorSource #5074

wants to merge 1 commit into from

Conversation

brentvatne
Copy link
Collaborator

@brentvatne
[UIExplorer] Add defaultSource / loadingIndicatorSource
8e4f02b 
- Also re-order a bit and limit ImageSizeExample to iOS
@brentvatne
Copy link
Collaborator Author

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @amasad, @sahrens and @nicklockwood to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 1, 2016
@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1680276885585191/int_phab to review.

@brentvatne brentvatne mentioned this pull request Jan 2, 2016
Closed
@bestander
Copy link
Contributor

@nicklockwood is comandeering the revision manually

@nicklockwood
Copy link
Contributor

@brentvatne it turns out that loadingIndicatorSource is something that was added hastily for an internal use case, and it's not something we want to support as it has really weird semantics that are very specific to how Fresco works internally.

I'm still considering whether we want to keep defaultSource. It's potentially useful, but only if it can be ported to Android, I think.

@brentvatne brentvatne mentioned this pull request Jan 6, 2016
Closed
@brentvatne
Copy link
Collaborator Author

Ah great to know, thanks for the follow up @nicklockwood! I created an issue for that at #5158 :) No need to keep this one open.

@brentvatne brentvatne closed this Jan 6, 2016
ghost pushed a commit that referenced this pull request Feb 1, 2016
@brentvatne
Add defaultSource example
cb2eeb4 
Summary: Closes #5074

Reviewed By: svcscm

Differential Revision: D2798023

Pulled By: nicklockwood

fb-gh-sync-id: d8aa87bf8dcbecf53b341d5914bbe3354cc753aa
@ide ide deleted the uiexplorer-image-example-fixes branch March 11, 2016 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brentvatne @facebook-github-bot @bestander @nicklockwood @skevy