Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListView sticky headers are offset when RefreshControl is active #5405

Closed
samuelkraft opened this issue Jan 19, 2016 · 12 comments
Closed

ListView sticky headers are offset when RefreshControl is active #5405

samuelkraft opened this issue Jan 19, 2016 · 12 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@samuelkraft
Copy link

When using a ListView with "renderSectionHeader" together with RefreshControl the sticky headers will be offset during refreshing. To reproduce pull down to refresh and then scroll back up before the refresh finishes. This is an issue on both 0.17 (onRefreshStart) and 0.18 (RefreshControl).
Gif:
stickyheaderrefresh
@facebook-github-bot
Copy link
Contributor

Hey samuelkraft, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

  • If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
  • If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
  • We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!

@janicduplessis janicduplessis mentioned this issue Jan 24, 2016
Closed
@janicduplessis
Copy link
Contributor

Thanks for reporting this, I just submitted a PR to fix it!

@samuelkraft
Copy link
Author

Thanks! Let's hope for a merge soon 👍

@ghost ghost closed this as completed in 34389c5 Feb 3, 2016
@janicduplessis
Copy link
Contributor

There you go :)

@samuelkraft
Copy link
Author

Yay! 🎉

pglotov pushed a commit to pglotov/react-native that referenced this issue Mar 15, 2016
@janicduplessis @pglotov
Fix sticky headers position when scrolling while RefreshControl is re…
a68d28b 
…freshing

Summary:
When scrolling while RefreshControl is refreshing the sticky headers are offset by the height of the UIRefreshControl. This simply removes the height of the UIRefreshControl while it is refreshing and fixes the problem.

You can repro the bug using this example in UIExplorer by doing a pull to refresh and scrolling the ListView immediately after.
https://gist.github.com/janicduplessis/26b4f2758e90b2aa1620

Fixes facebook#5405
Closes facebook#5517

Reviewed By: svcscm

Differential Revision: D2895623

Pulled By: nicklockwood

fb-gh-sync-id: 81df36cccfc3e7b973c2be78565f8b8408c9fc12
@tomauty
Copy link
Contributor

tomauty commented Aug 4, 2016

I think this regressed somewhere along the way.

@pfeiffer
Copy link
Contributor

pfeiffer commented Oct 4, 2016

Yup, this is still present in 0.34

@idris
Copy link

idris commented Oct 5, 2016

@janicduplessis should this issue be re-opened? Or is there a new issue somewhere?

@siwonia
Copy link

siwonia commented Nov 24, 2016

Still present in 0.38

@krailler
Copy link

Same issue in 0.40 :/

@catarinasoliveira
Copy link

Same problem in 0.42.0 :/

@putuyoga
Copy link

same problem here

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone