Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.facebook.react:react-native:0.19.0 @ReactProp issue on android #5649

Closed
soxunyi opened this issue Jan 31, 2016 · 8 comments
Closed

com.facebook.react:react-native:0.19.0 @ReactProp issue on android #5649

soxunyi opened this issue Jan 31, 2016 · 8 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@soxunyi
Copy link

soxunyi commented Jan 31, 2016

If you use android native view, and annotations ReactProp. Please import the right ReactProp class, import com.facebook.react.uimanager.annotations.ReactProp, rather than import com.facebook.react.uimanager.ReactProp.

com.facebook.react.uimanager.ReactProp is not work on 0.19.0.

Why do not remove this class on 0.19.0?

@facebook-github-bot
Copy link
Contributor

Hey soxunyi, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

  • If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
  • If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
  • We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!

@rpopovici
Copy link

temporary fix for this is to add the following to your build.gradle

android {
...
lintOptions {
warning 'InvalidPackage'
}
}

dependencies {
...
compile 'com.facebook.react:react-native:0.19.+'
}

and then import com.facebook.react.uimanager.annotations.ReactProp

@deminoth
Copy link
Contributor

+1. import com.facebook.react.uimanager.ReactProp does not showing any error but not working. We should notify using import com.facebook.react.uimanager.annotations.ReactProp to developer.

@janicduplessis
Copy link
Contributor

This was a breaking change in 0.19, sorry if it was not communicated properly.

@janicduplessis
Copy link
Contributor

@facebook-github-bot answered

@facebook-github-bot
Copy link
Contributor

Closing this issue as @janicduplessis says the question asked has been answered. Please help us by asking questions on StackOverflow. StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only.

@facebook-github-bot facebook-github-bot added the Ran Commands One of our bots successfully processed a command. label Mar 20, 2016
@taypo
Copy link

taypo commented Apr 4, 2016

Lost two days on this. Please make a remark on the documentation.

@fiattt
Copy link

fiattt commented May 6, 2016

Lost one days on this - -!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

9 participants