-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] JS tests on Travis CI hang after completion #6019
Comments
Yeah it is likely haste 2 and file watching. Pretty sure it is one of these two: https://github.com/facebook/jest/blob/master/src/resolvers/HasteResolver.js#L117 – maybe persisting the cache or for some reason it can't stop watching the file system? Can you somehow trigger a run just without properly ending either of these? |
@cpojer I'm pretty sure it does have to do with the filewatcher...I encountered this when I was using node-haste elsewhere. I had to explicitly call |
ohhhhh... I noticed this in Jest too when I was creating a real FileWatcher instance in one of my tests and then I didn't kill that one. Are we doing this anywhere in the tests for react-native? Like, create an unmocked instance of FileWatcher that we don't call .end() on? |
Summary:Fixes #714, probably also #722 and also facebook/react-native#6019 Closes #724 Differential Revision: D2953708 fb-gh-sync-id: 110a30d6c11256644c8e4f7ab1d7b7cb5fa1b021 shipit-source-id: 110a30d6c11256644c8e4f7ab1d7b7cb5fa1b021
Ide, this is fixed now, right? Feel free to reopen if its still an issue. |
LGTM, tests are failing instead of erroring so that's good. |
Hi, We are getting this same issue on travis now. It works fine on local . Only on travis it just hangs |
It appears likely to be related to the Haste 2 change (cc @cpojer). The JS, CLI, and packager tests all run Jest and terminate with:
https://travis-ci.org/facebook/react-native/builds/110065663
This is the build log, which makes me think something in Haste 2 is the cause:
The text was updated successfully, but these errors were encountered: