Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] JS tests on Travis CI hang after completion #6019

Closed
ide opened this issue Feb 19, 2016 · 6 comments
Closed

[Tests] JS tests on Travis CI hang after completion #6019

ide opened this issue Feb 19, 2016 · 6 comments
Assignees
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Feb 19, 2016

It appears likely to be related to the Haste 2 change (cc @cpojer). The JS, CLI, and packager tests all run Jest and terminate with:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

https://travis-ci.org/facebook/react-native/builds/110065663

This is the build log, which makes me think something in Haste 2 is the cause:

screenshot 2016-02-18 18 05 58

@cpojer
Copy link
Contributor

cpojer commented Feb 19, 2016

Yeah it is likely haste 2 and file watching. Pretty sure it is one of these two: https://github.com/facebook/jest/blob/master/src/resolvers/HasteResolver.js#L117 – maybe persisting the cache or for some reason it can't stop watching the file system?

Can you somehow trigger a run just without properly ending either of these?

@skevy
Copy link
Contributor

skevy commented Feb 19, 2016

@cpojer I'm pretty sure it does have to do with the filewatcher...I encountered this when I was using node-haste elsewhere. I had to explicitly call .end() which is something we're probably not doing in these tests anywhere.

@cpojer
Copy link
Contributor

cpojer commented Feb 19, 2016

ohhhhh... I noticed this in Jest too when I was creating a real FileWatcher instance in one of my tests and then I didn't kill that one. Are we doing this anywhere in the tests for react-native? Like, create an unmocked instance of FileWatcher that we don't call .end() on?

ghost pushed a commit to jestjs/jest that referenced this issue Feb 19, 2016
Summary:Fixes #714, probably also #722 and also facebook/react-native#6019
Closes #724

Differential Revision: D2953708

fb-gh-sync-id: 110a30d6c11256644c8e4f7ab1d7b7cb5fa1b021
shipit-source-id: 110a30d6c11256644c8e4f7ab1d7b7cb5fa1b021
@cpojer
Copy link
Contributor

cpojer commented Feb 19, 2016

Ide, this is fixed now, right? Feel free to reopen if its still an issue.

@cpojer cpojer closed this as completed Feb 19, 2016
@ide
Copy link
Contributor Author

ide commented Feb 19, 2016

LGTM, tests are failing instead of erroring so that's good.

@a7ul
Copy link

a7ul commented Apr 28, 2017

Hi, We are getting this same issue on travis now.
We are using "jest": "^19.0.2"
Any solution or
workaround ?

It works fine on local . Only on travis it just hangs

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants