Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pod lib lint fails #6448

Closed
hfossli opened this issue Mar 14, 2016 · 5 comments
Closed

pod lib lint fails #6448

hfossli opened this issue Mar 14, 2016 · 5 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@hfossli
Copy link
Contributor

hfossli commented Mar 14, 2016

Running the command pod lib lint to validate the podspec fails with the following error:

 -> React (0.21.0)
    - WARN  | [React/Core, React/ART, React/RCTActionSheet, and more...] xcodebuild:  /Users/hfossli/Projects/ReactNative/React/Base/RCTBatchedBridge.m:626:6: warning: code will never be executed [-Wunreachable-code]
    - WARN  | [React/Core, React/ART, React/RCTActionSheet, and more...] xcodebuild:  /Users/hfossli/Projects/ReactNative/React/Base/RCTBatchedBridge.m:874:21: warning: unused variable 'newFlowID' [-Wunused-variable]
    - WARN  | [React/Core, React/ART, React/RCTActionSheet, and more...] xcodebuild:  /Users/hfossli/Projects/ReactNative/React/Modules/RCTSourceCode.m:33:29: warning: code will never be executed [-Wunreachable-code]
    - WARN  | [React/Core, React/ART, React/RCTActionSheet, and more...] xcodebuild:  /Users/hfossli/Projects/ReactNative/React/Modules/RCTUIManager.m:327:11: warning: unused variable 'existingView' [-Wunused-variable]
    - ERROR | [React/RCTCameraRoll,React/RCTTest] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | [iOS] [React/RCTCameraRoll] xcodebuild:  /Users/hfossli/Projects/ReactNative/Libraries/CameraRoll/RCTCameraRollManager.m:19:9: fatal error: 'RCTImageLoader.h' file not found
    - NOTE  | [iOS] [React/RCTTest] xcodebuild:  /Users/hfossli/Projects/ReactNative/Libraries/RCTTest/RCTSnapshotManager.h:10:9: fatal error: 'RCTViewManager.h' file not found
    - NOTE  | [iOS] [React/RCTTest] xcodebuild:  /Users/hfossli/Projects/ReactNative/Libraries/RCTTest/RCTTestModule.h:12:9: fatal error: 'RCTBridgeModule.h' file not found
    - NOTE  | [iOS] [React/RCTTest] xcodebuild:  /Users/hfossli/Projects/ReactNative/Libraries/RCTTest/RCTTestRunner.m:13:9: fatal error: 'RCTAssert.h' file not found

Reproduce by:

  1. Checkout v0.21.0 or v0.22.0-rc.
  2. Run pod lib lint

I'm not sure why this happens. Any ideas? If I remove the failing subspecs (RCTCameraRoll and RCTTest) everything is fine.
@hfossli
Copy link
Contributor Author

hfossli commented Mar 14, 2016

Looking at blame logs it seems like @nicklockwood, @dvcrn and @vjeux might be able to comment on RCTCameraRoll.

@mkonicek
Copy link
Contributor

@hfossli We're a small team and rely on the community to fix issues that don't affect fb apps. We don't use pod internally. If you know how to fix this can you send a PR?

@hfossli
Copy link
Contributor Author

hfossli commented Mar 20, 2016

I'll get back to you after easter holidays

@mkonicek
Copy link
Contributor

@hfossli 👍 sounds good :)

jesseluo added a commit to jesseluo/react-native that referenced this issue Apr 13, 2016
@jesseluo
Fix failure of pod lib lint, which will close facebook#6448. Tested…
ba4375b 
… on 0.23.0.
@jesseluo
Copy link
Contributor

Hi, I've created a PR to fix this issue which may block all the pod using React Native passing lint.

@ghost ghost closed this as completed in ef044e2 Apr 13, 2016
zebulgar pushed a commit to nightingale/react-native that referenced this issue Jun 18, 2016
@jesseluo @zebulgar
Fix failure of pod lib lint, which will close facebook#6448. Tested…
ce45608 
… on 0.23.0.

Summary:The subspec should declare enough dependencies. Or the lint of podspec file will fail because CoaoaPods will not import necessary source on the building step.
Closes facebook#6955

Differential Revision: D3174681

fb-gh-sync-id: 59315efaeeb949951d7ee8e55dc7c979fcea4fbf
fbshipit-source-id: 59315efaeeb949951d7ee8e55dc7c979fcea4fbf
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mkonicek @jesseluo @hfossli @react-native-bot