Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] ToolbarAndroid tablet padding too much #6964

Closed
ssomnoremac opened this issue Apr 13, 2016 · 2 comments
Closed

[Android] ToolbarAndroid tablet padding too much #6964

ssomnoremac opened this issue Apr 13, 2016 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ssomnoremac
Copy link

On RN@master

With ToolbarAndroid when you are using a tablet or a larger screen, the margin for the NavIcon is consistently too much or gravity is not set correctly. I've used vector icons and drawables both with the same result. Would prefer not to have to target each size screen with conditional styling.

nexus7

@ssomnoremac
Copy link
Author

From the Android docs on Toolbar it appears that:

The navigation button is vertically aligned within the Toolbar's minimum height, if set.

Yet it appears the issue is closed on setting min-height in React Native which, I'm not sure is enough to get this solved as it looks shifted to the right as well, but it might be heading in the right direction.

@lacker
Copy link
Contributor

lacker commented Oct 21, 2016

It seems like css-layout has been updated since this was an issue and from that other issue it seems like that was the main problem here. I'm going to close this issue under the theory that it is solved by that, but if it's still a problem feel free to reopen.

@lacker lacker closed this as completed Oct 21, 2016
@facebook facebook locked as resolved and limited conversation to collaborators Jul 19, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants