New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for TextInput don't say what styles it can take, incorrectly hint that they can handle all Text styles #7070
Comments
@dimitrovskif So far I've only tested this on iOS. |
@dimitrovskif I've not, but since it works for |
@dimitrovskif I'm really not sure what point you're trying to make, it shouldn't make any difference what Apple or Google support natively in their controls. The docs should represent what is supported by React Native, leaving everyone to find it out blindly (some of them are explicitly listed as being only available on iOS as well) isn't a great experience for anyone. |
@dimitrovskif in fact, our docs are saying it accepts the same style https://facebook.github.io/react-native/docs/textinput.html#style @seanparsons you can wrap your I think docs need some clarifying. Here's the rnplay: https://rnplay.org/apps/EdJtJQ |
Yeah, these docs are pretty bad right now - in particular https://facebook.github.io/react-native/docs/textinput.html#style says nothing but that should probably be a concise description of which styles work and which don't. |
Bandaid for facebook#7070. Until this is fixed, the docs should at least be honest the state they're in, so people don't have to go search and wonder.
Summary: Bandaid for facebook#7070. Until this is fixed, the docs should at least be honest the state they're in, so people don't have to go search and wonder. Closes facebook#11626 Differential Revision: D4366925 Pulled By: mkonicek fbshipit-source-id: 082a8a9916ad0f8fbb2955cffbf61142fa2a98a1
Summary: Bandaid for facebook#7070. Until this is fixed, the docs should at least be honest the state they're in, so people don't have to go search and wonder. Closes facebook#11626 Differential Revision: D4366925 Pulled By: mkonicek fbshipit-source-id: 082a8a9916ad0f8fbb2955cffbf61142fa2a98a1
Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why. |
Given that the docs still don't actually say which styles will actually work don't you think closing the issue is premature? |
Good point. I've been tackling docs issues, so I'll just assign this to myself. |
Coming here from the documentation about TextField: it seems that replacing the font family is not working on Android. Is this one of the styles that is not supported? I’m surprised that I did not find any issue specifically about that, so I think I might have missed something. |
I'm having trouble setting in |
@RUIFERNANDE5 use |
Hi @hramos ! I am new to Open Source and want to dive into this issue, though i could see you have assigned it to yourself, it is possible you re-assign it to me so i can get started with contributing. |
Sure! Thanks for volunteering 🙌 |
All yours |
Hi @hramos , to get started, i guess i would have to check out Text styles that do not work for TextInput component and list them because the doc has already being updated with the below hint: 'Note that not all Text styles are supported, see Issue#7070 for more detail.' |
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
Hi, this is still not resolved: http://facebook.github.io/react-native/releases/0.50/docs/textinput.html Please reopen and throw together a simple bullet point list of what is supported. |
@marcind please open a PR and I'll take a look |
Sorry, I'm not familiar with the internal workings of react-native so wouldn't know where to start to figure this out (other than trying every style property in some sample to see what works and what does not). I was hoping that someone who maintains this project has enough knowledge to quickly provide a list. |
Summary: References #7070 <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Docs are incomplete, start filling them out N/A Closes #16346 Differential Revision: D6057501 Pulled By: hramos fbshipit-source-id: c30d3369fa1a73ef6a93c2ed8f8c53af5a1af7ee
According to the docs for TextInput it supports the same styling options as Text. In testing this at the bare minimum all of the shadow and line decoration options aren't supported.
This can be seen in this playground:
https://rnplay.org/apps/sdqbqw
If the
Text
element is replaced with aTextInput
element with the same style the shadow is lost.I can imagine that the native text input element isn't conducive to supporting shadows, which is why this is happening.
The text was updated successfully, but these errors were encountered: