Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Multiple request handler error when uploading a photo from assets-library #9031

Closed
halilb opened this issue Jul 26, 2016 · 4 comments
Closed

[iOS] Multiple request handler error when uploading a photo from assets-library #9031

halilb opened this issue Jul 26, 2016 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@halilb
Copy link

halilb commented Jul 26, 2016

I'm getting the following error when I try uploading a photo from asset-library.

The RCTURLRequestHandlers RCTImageLoader and RCTAssetsLibraryRequestHandler both reported that they can handle the request { URL: assets-library://asset/asset.JPG?id=9F983&ext=JPG}, and have equal priority (0). This could result in non-deterministic behavior.

You can reproduce the problem by opening XMLHttpRequest example from UIExplorer project and simply tapping on Upload button.

I tracked down the problem and it seems it's introduced with commit 98f06c8.
halilb referenced this issue Jul 26, 2016
@nathanajah
Allow RCTPhotoLibraryImageLoader to handle assets-library request
98f06c8 
Reviewed By: javache

Differential Revision: D3503380

fbshipit-source-id: 8f8eb545343738906e44ee01aa4ba23755a209c7
@nathanajah
Copy link
Contributor

Thanks for reporting! I'll fix it.

@ghost ghost closed this as completed in ffb690f Jul 27, 2016
gabceb pushed a commit to tes/react-native that referenced this issue Jul 27, 2016
@nathanajah @gabceb
Fix RCTImageLoader's priority
ef909a3 
Summary:
There is a conflict between RCTImageLoader and RCTAssetsLibraryRequestHandler on handling images, which was caused by making RCTPhotoLibraryImageLoader able to handle assets library requests as well. This gives more priority to RCTImageLoader instead.
Fixes facebook#9031.

Reviewed By: mmmulani

Differential Revision: D3627451

fbshipit-source-id: 7ffd2c66f43ce1479c9a117768fb2d29f9d0dc08
grabbou pushed a commit that referenced this issue Aug 1, 2016
@nathanajah @grabbou
Fix RCTImageLoader's priority
07a9701 
Summary:
There is a conflict between RCTImageLoader and RCTAssetsLibraryRequestHandler on handling images, which was caused by making RCTPhotoLibraryImageLoader able to handle assets library requests as well. This gives more priority to RCTImageLoader instead.
Fixes #9031.

Reviewed By: mmmulani

Differential Revision: D3627451

fbshipit-source-id: 7ffd2c66f43ce1479c9a117768fb2d29f9d0dc08
bartolkaruza pushed a commit to immidi/react-native that referenced this issue Aug 3, 2016
@nathanajah
Fix RCTImageLoader's priority
ba6b158 
Summary:
There is a conflict between RCTImageLoader and RCTAssetsLibraryRequestHandler on handling images, which was caused by making RCTPhotoLibraryImageLoader able to handle assets library requests as well. This gives more priority to RCTImageLoader instead.
Fixes facebook#9031.

Reviewed By: mmmulani

Differential Revision: D3627451

fbshipit-source-id: 7ffd2c66f43ce1479c9a117768fb2d29f9d0dc08
@alexanderjarvis
Copy link

@nathanajah the introduction of this 98f06c8#diff-6c79938e43c7e10abca60323d26f1935 disables the ability to upload video using an asset-library url

@jbrozena22 jbrozena22 mentioned this issue Aug 5, 2016
Closed
samerce pushed a commit to iodine/react-native that referenced this issue Aug 23, 2016
@nathanajah @samerce
Fix RCTImageLoader's priority
36edbf0 
Summary:
There is a conflict between RCTImageLoader and RCTAssetsLibraryRequestHandler on handling images, which was caused by making RCTPhotoLibraryImageLoader able to handle assets library requests as well. This gives more priority to RCTImageLoader instead.
Fixes facebook#9031.

Reviewed By: mmmulani

Differential Revision: D3627451

fbshipit-source-id: 7ffd2c66f43ce1479c9a117768fb2d29f9d0dc08
mpretty-cyro pushed a commit to HomePass/react-native that referenced this issue Aug 25, 2016
@nathanajah
Fix RCTImageLoader's priority
53c5c97 
Summary:
There is a conflict between RCTImageLoader and RCTAssetsLibraryRequestHandler on handling images, which was caused by making RCTPhotoLibraryImageLoader able to handle assets library requests as well. This gives more priority to RCTImageLoader instead.
Fixes facebook#9031.

Reviewed By: mmmulani

Differential Revision: D3627451

fbshipit-source-id: 7ffd2c66f43ce1479c9a117768fb2d29f9d0dc08
@jslz
Copy link

jslz commented Jun 9, 2017 •
edited

hi, We seem to be seeing it with react-native version 0.44.0. It is rare and nondeterministic so hard to have a repro case. (sorry this image is always coming through giant here.)
image

@arjunkathuria
Copy link

arjunkathuria commented Jul 10, 2017 •
edited

^ +1, same issues as @jslz, RN 0.44, any fixes ?

@tsjamm tsjamm mentioned this issue Oct 1, 2017
Closed
dryganets pushed a commit to dryganets/react-native that referenced this issue Oct 3, 2017
@nathanajah
Fix RCTImageLoader's priority
a9ca433 
Summary:
There is a conflict between RCTImageLoader and RCTAssetsLibraryRequestHandler on handling images, which was caused by making RCTPhotoLibraryImageLoader able to handle assets library requests as well. This gives more priority to RCTImageLoader instead.
Fixes facebook#9031.

Reviewed By: mmmulani

Differential Revision: D3627451

fbshipit-source-id: 7ffd2c66f43ce1479c9a117768fb2d29f9d0dc08
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@alexanderjarvis @halilb @nathanajah @arjunkathuria @jslz @react-native-bot