-
Notifications
You must be signed in to change notification settings - Fork 24.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes babel-register for Windows paths #10154
Conversation
By analyzing the blame information on this pull request, we identified @janicduplessis and @sam-swarr to be potential reviewers. |
babel-core (used by babel-register) takes a dependency on slash, which only "normalizes" paths (with '/') if they consist of only ASCII characters. So, babel-register breaks down for any React Native users on Windows when their project paths contain non-ASCII characters. |
This would be redundant if babel/babel#4631 gets accepted. |
We may want to consider merging this, as I don't know when or if the change to babel will be accepted. |
The babel PR is accepted, so once the next version of babel is released, we can close out this PR and instead upgrade babel. |
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @davidaurelio as a potential reviewer. Could you take a look please or cc someone with more context? |
@rozele do you still plan to ship this? |
|
Babel was not compiling anything from react-packager/src when run from Windows, including the recently added node-haste stuff, which has been causing problems for some people. This change fixes that.
Fixes #10033
Fixes #8899