Make react-devtools server port can be changed #10522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @davidaurelio and @sebmarkbage to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mlguys
pushed a commit
to mlguys/react-native
that referenced
this pull request
Nov 8, 2016
Summary: This PR make [server port of react-devtools](https://github.com/facebook/react-devtools/blob/master/shells/electron/index.html#L71) can be changed, currently we can set the port yourself and open it, so I think it would be better if it could also be set here. Another reason is I can debug two RN app (`react-native start --port 8082`), but I cannot let them use react-devtools together, it would be better if I set different `__REACT_DEVTOOLS_PORT__` in `index.ios.js` and `index.android.js`. Closes facebook#10522 Differential Revision: D4144011 Pulled By: hramos fbshipit-source-id: de67931f377092871a0fe92e7d9a18799625217e
4 tasks
hramos
added
the
Import Started
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: This PR make [server port of react-devtools](https://github.com/facebook/react-devtools/blob/master/shells/electron/index.html#L71) can be changed, currently we can set the port yourself and open it, so I think it would be better if it could also be set here. Another reason is I can debug two RN app (`react-native start --port 8082`), but I cannot let them use react-devtools together, it would be better if I set different `__REACT_DEVTOOLS_PORT__` in `index.ios.js` and `index.android.js`. Closes facebook#10522 Differential Revision: D4144011 Pulled By: hramos fbshipit-source-id: de67931f377092871a0fe92e7d9a18799625217e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make server port of react-devtools can be changed, currently we can set the port yourself and open it, so I think it would be better if it could also be set here.
Another reason is I can debug two RN app (
react-native start --port 8082), but I cannot let them use react-devtools together, it would be better if I setdifferent
__REACT_DEVTOOLS_PORT__inindex.ios.jsandindex.android.js.