[Android] Deprecate RecyclerViewBackedScrollView #11095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkonicek
force-pushed
the
deprecate_recyclerview
branch
from
311d53e
to
e9ca906
Compare
This was referenced Nov 23, 2016
Closed
|
After some discussion a better option seems to move this to a separate repo as we're not using this internally at fb but some people use this. |
eslint-bot
reviewed
Nov 23, 2016
| @@ -58,6 +64,14 @@ var RecyclerViewBackedScrollView = React.createClass({ | |||
|
|
|||
| mixins: [ScrollResponder.Mixin], | |||
|
|
|||
| componentWillMount: function() { | |||
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 16, 2016
Summary: cc brentvatne potential reviewers mkonicek and kmagiera **Motivation for making this change.** The previous PR was closed : #11095 but the followup actions was never done I reopened a really similar one so it get merged RecyclerView is no more used at Facebook (according to previous PR) According to brentvatne, their were two motivations for RecyclerView: * ListView with ScrollView component used to bounce back on row insert, but this is now fixed * This made possible to implement certain performance improvements, but the maintenance cost was not worth the risk With RN 0.37, the actual code in React Native make the app crash: - see #10560 I spend one hour investigating this and did also require brent time at exponent slack. I think other people are struggling too. **Test plan** <img width="708" alt="screen shot 2016-12-13 at 23 42 22" src="https://cloud.githubusercontent.com/assets/13785185/21162483/dbeb642e-c18d-11e6-9c32-1fe73f1826c1.png"> **Code formatting** The Closes #11445 Differential Revision: D4340640 Pulled By: mkonicek fbshipit-source-id: 64c5cf060f2eb035d4d6199b30f0e73afc520180
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: cc brentvatne potential reviewers mkonicek and kmagiera **Motivation for making this change.** The previous PR was closed : facebook#11095 but the followup actions was never done I reopened a really similar one so it get merged RecyclerView is no more used at Facebook (according to previous PR) According to brentvatne, their were two motivations for RecyclerView: * ListView with ScrollView component used to bounce back on row insert, but this is now fixed * This made possible to implement certain performance improvements, but the maintenance cost was not worth the risk With RN 0.37, the actual code in React Native make the app crash: - see facebook#10560 I spend one hour investigating this and did also require brent time at exponent slack. I think other people are struggling too. **Test plan** <img width="708" alt="screen shot 2016-12-13 at 23 42 22" src="https://cloud.githubusercontent.com/assets/13785185/21162483/dbeb642e-c18d-11e6-9c32-1fe73f1826c1.png"> **Code formatting** The Closes facebook#11445 Differential Revision: D4340640 Pulled By: mkonicek fbshipit-source-id: 64c5cf060f2eb035d4d6199b30f0e73afc520180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use this component internally and seems like it's not needed.
From the docs of this component it looks like there's no point in its existence:
I'd like to deprecate this component we don't use it at fb and it has a maintenance cost, e.g.: #7002